fix: MR review lint errors

Author: Times-Z

src/components/bar/modules/media/index.tsx

@@ -27,10 +27,13 @@ const { ignore } = options.menus.media;
 
 const isVis = Variable(!show_active_only.get());
 
-Variable.derive([bind(show_active_only), bind(mprisService, 'players'), bind(ignore)], (showActive, players, ignoredApps) => {
-    const filteredPlayers = filterPlayers(players, ignoredApps);
-    isVis.set(!showActive || filteredPlayers?.length > 0);
-});
+Variable.derive(
+    [bind(show_active_only), bind(mprisService, 'players'), bind(ignore)],
+    (showActive, players, ignoredApps) => {
+        const filteredPlayers = filterPlayers(players, ignoredApps);
+        isVis.set(!showActive || filteredPlayers?.length > 0);
+    },
+);
 
 const Media = (): BarBoxChild => {
     const allPlayers = mprisService.get_players();

src/components/menus/media/components/controls/helpers.ts

@@ -93,8 +93,9 @@ export const getNextPlayer = (): void => {
     const allPlayers = mprisService.get_players();
     const filteredPlayers = filterPlayers(allPlayers, ignore.get());
 
-    const currentPlayerIndex = filteredPlayers
-        .findIndex((player) => player.busName === currentPlayer.busName);
+    const currentPlayerIndex = filteredPlayers.findIndex(
+        (player) => player.busName === currentPlayer.busName,
+    );
     const totalPlayers = filteredPlayers.length;
 
     if (totalPlayers === 1) {
@@ -123,15 +124,14 @@ export const getPreviousPlayer = (): void => {
     const allPlayers = mprisService.get_players();
     const filteredPlayers = filterPlayers(allPlayers, ignore.get());
 
-    const currentPlayerIndex = filteredPlayers
-        .findIndex((player) => player.busName === currentPlayer.busName);
+    const currentPlayerIndex = filteredPlayers.findIndex(
+        (player) => player.busName === currentPlayer.busName,
+    );
     const totalPlayers = filteredPlayers.length;
 
     if (totalPlayers === 1) {
         return activePlayer.set(filteredPlayers[0]);
     }
 
-    return activePlayer.set(
-        filteredPlayers[(currentPlayerIndex - 1 + totalPlayers) % totalPlayers],
-    );
+    return activePlayer.set(filteredPlayers[(currentPlayerIndex - 1 + totalPlayers) % totalPlayers]);
 };

src/lib/shared/media/index.ts

@@ -2,25 +2,6 @@ import AstalMpris from 'gi://AstalMpris?version=0.1';
 
 const normalizeName = (name: string): string => name.toLowerCase().replace(/\s+/g, '_');
 
-/**
- * Gets the desktop entry name from an MPRIS player.
- *
- * The desktop entry typically contains the actual application name,
- * which is more reliable than the bus name for Electron apps.
- *
- * @param player The MPRIS player.
- *
- * @returns The desktop entry name or empty string.
- */
-const getDesktopEntry = (player: AstalMpris.Player): string => {
-    try {
-        return player.entry || '';
-    } catch {
-        return '';
-    }
-};
-
-
 /**
  * Checks if a media player should be ignored based on the filter list.
  *
@@ -32,10 +13,7 @@ const getDesktopEntry = (player: AstalMpris.Player): string => {
  *
  * @returns True if the player should be ignored, false otherwise.
  */
-export const isPlayerIgnored = (
-    player: AstalMpris.Player | null | undefined,
-    filter: string[],
-): boolean => {
+export const isPlayerIgnored = (player: AstalMpris.Player | null | undefined, filter: string[]): boolean => {
     if (!player) {
         return false;
     }
@@ -44,7 +22,7 @@ export const isPlayerIgnored = (
 
     const identity = player.identity || '';
     const normalizedIdentity = normalizeName(identity);
-    
+
     return playerFilters.has(normalizedIdentity);
 };
 
@@ -58,10 +36,7 @@ export const isPlayerIgnored = (
  *
  * @returns Filtered array of players.
  */
-export const filterPlayers = (
-    players: AstalMpris.Player[],
-    filter: string[],
-): AstalMpris.Player[] => {
+export const filterPlayers = (players: AstalMpris.Player[], filter: string[]): AstalMpris.Player[] => {
     const filteredPlayers = players.filter((player: AstalMpris.Player) => {
         return !isPlayerIgnored(player, filter);
     });

src/services/media/index.ts

@@ -63,8 +63,8 @@ export class MediaPlayerService {
 
         const preferred = preferredPlayer.get();
         if (preferred) {
-            const preferredPlayerMatch = filteredPlayers.find(
-                player => player.identity?.toLowerCase().includes(preferred.toLowerCase())
+            const preferredPlayerMatch = filteredPlayers.find((player) =>
+                player.identity?.toLowerCase().includes(preferred.toLowerCase()),
             );
             if (preferredPlayerMatch) {
                 this.activePlayer.set(preferredPlayerMatch);
@@ -112,7 +112,8 @@ export class MediaPlayerService {
         }
 
         const preferred = preferredPlayer.get();
-        const isPreferred = preferred && addedPlayer.identity?.toLowerCase().includes(preferred.toLowerCase());
+        const isPreferred =
+            preferred && addedPlayer.identity?.toLowerCase().includes(preferred.toLowerCase());
 
         if (this.activePlayer.get() === undefined || isPreferred) {
             this.activePlayer.set(addedPlayer);
@@ -132,16 +133,12 @@ export class MediaPlayerService {
         const allPlayers = this._mprisService.get_players();
         const filteredPlayers = filterPlayers(allPlayers, ignore.get());
 
-        if (
-            filteredPlayers.length === 1 &&
-            closedPlayer.busName === filteredPlayers[0]?.busName
-        ) {
+        if (filteredPlayers.length === 1 && closedPlayer.busName === filteredPlayers[0]?.busName) {
             return this.activePlayer.set(undefined);
         }
 
         if (closedPlayer.busName === this.activePlayer.get()?.busName) {
-            const nextPlayer = filteredPlayers
-                .find((player) => player.busName !== closedPlayer.busName);
+            const nextPlayer = filteredPlayers.find((player) => player.busName !== closedPlayer.busName);
             this.activePlayer.set(nextPlayer);
         }
     }