Skip to content

Commit 2e927ee

Browse files
schultzp202004kash
andauthored
chore: add wrapper tests (redhat-developer#1874)
* chore: add wrapper tests Signed-off-by: Paul Schultz <[email protected]> * misc fixes Signed-off-by: Paul Schultz <[email protected]> * fix errors indicated by wrapper tests Signed-off-by: Kashish Mittal <[email protected]> * refactor tests Signed-off-by: Paul Schultz <[email protected]> * fix tests Signed-off-by: Paul Schultz <[email protected]> * add missing changes Signed-off-by: Paul Schultz <[email protected]> * update var names Signed-off-by: Paul Schultz <[email protected]> --------- Signed-off-by: Paul Schultz <[email protected]> Signed-off-by: Kashish Mittal <[email protected]> Co-authored-by: Kashish Mittal <[email protected]>
1 parent cc9556a commit 2e927ee

File tree

19 files changed

+520
-199
lines changed

19 files changed

+520
-199
lines changed

.github/workflows/pr.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,6 @@ jobs:
9595

9696
- name: Run tests
9797
run: yarn run test --concurrency=75% --affected
98+
99+
- name: Verify wrappers
100+
run: yarn workspace dynamic-plugins-utils run test:wrappers

.ibm/pipelines/value_files/values_showcase-rbac.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ global:
3030
seconds: 15
3131
- package: ./dynamic-plugins/dist/backstage-plugin-catalog-backend-module-github-org-dynamic
3232
disabled: false
33-
- package: ./dynamic-plugins/dist/backstage-plugin-github-issues
33+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-issues
3434
disabled: false
3535
- package: ./dynamic-plugins/dist/roadiehq-backstage-plugin-github-pull-requests
3636
disabled: false
37-
- package: ./dynamic-plugins/dist/backstage-plugin-github-actions
37+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-actions
3838
disabled: false
3939
- package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-quay
4040
disabled: false
@@ -97,7 +97,7 @@ global:
9797
- package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-bulk-import
9898
disabled: false
9999
# Enable tech-radar plugin.
100-
- package: ./dynamic-plugins/dist/backstage-plugin-tech-radar
100+
- package: ./dynamic-plugins/dist/backstage-community-plugin-tech-radar
101101
disabled: false
102102
- package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-rbac
103103
disabled: false

.ibm/pipelines/value_files/values_showcase.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ global:
3232
seconds: 15
3333
- package: ./dynamic-plugins/dist/backstage-plugin-catalog-backend-module-github-org-dynamic
3434
disabled: false
35-
- package: ./dynamic-plugins/dist/backstage-plugin-github-issues
35+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-issues
3636
disabled: false
3737
- package: ./dynamic-plugins/dist/roadiehq-backstage-plugin-github-pull-requests
3838
disabled: false
39-
- package: ./dynamic-plugins/dist/backstage-plugin-github-actions
39+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-actions
4040
disabled: false
4141
- package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-quay
4242
disabled: false
@@ -95,7 +95,7 @@ global:
9595
- package: ./dynamic-plugins/dist/janus-idp-backstage-plugin-bulk-import
9696
disabled: false
9797
# Enable tech-radar plugin.
98-
- package: ./dynamic-plugins/dist/backstage-plugin-tech-radar
98+
- package: ./dynamic-plugins/dist/backstage-community-plugin-tech-radar
9999
disabled: false
100100
- package: ./dynamic-plugins/dist/backstage-community-plugin-acr
101101
disabled: false

app-config.dynamic-plugins.yaml

+16
Original file line numberDiff line numberDiff line change
@@ -428,3 +428,19 @@ dynamicPlugins:
428428
janus-idp.backstage-plugin-analytics-provider-segment:
429429
apiFactories:
430430
- importName: SegmentAnalyticsApi
431+
janus-idp.backstage-plugin-rbac:
432+
appIcons:
433+
- name: rbacIcon
434+
importName: RbacIcon
435+
module: RbacPlugin
436+
dynamicRoutes:
437+
- path: /rbac
438+
module: RbacPlugin
439+
importName: RbacPage
440+
menuItem:
441+
icon: rbacIcon
442+
text: RBAC
443+
menuItems:
444+
rbac:
445+
parent: admin
446+
icon: rbacIcon

dynamic-plugins.default.yaml

+20-23
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,12 @@ plugins:
2828
timeout:
2929
minutes: 15
3030

31-
- package: ./dynamic-plugins/dist/backstage-plugin-github-actions
31+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-actions
3232
disabled: true
3333
pluginConfig:
3434
dynamicPlugins:
3535
frontend:
36-
backstage.plugin-github-actions:
36+
backstage-community.plugin-github-actions:
3737
mountPoints:
3838
- mountPoint: entity.page.ci/cards
3939
importName: EntityGithubActionsContent
@@ -43,12 +43,12 @@ plugins:
4343
if:
4444
allOf:
4545
- isGithubActionsAvailable
46-
- package: ./dynamic-plugins/dist/backstage-plugin-github-issues
46+
- package: ./dynamic-plugins/dist/backstage-community-plugin-github-issues
4747
disabled: true
4848
pluginConfig:
4949
dynamicPlugins:
5050
frontend:
51-
backstage.plugin-github-issues:
51+
backstage-community.plugin-github-issues:
5252
mountPoints:
5353
- mountPoint: entity.page.issues/cards
5454
importName: GithubIssuesCard
@@ -322,19 +322,19 @@ plugins:
322322
- package: ./dynamic-plugins/dist/backstage-plugin-scaffolder-backend-module-azure-dynamic
323323
# TODO RHIDP-3187 - graduate this plugin to GA so it can be enabled by default
324324
disabled: true
325-
- package: ./dynamic-plugins/dist/backstage-plugin-azure-devops-backend-dynamic
325+
- package: ./dynamic-plugins/dist/backstage-community-plugin-azure-devops-backend-dynamic
326326
disabled: true
327327
pluginConfig:
328328
azureDevOps:
329329
host: dev.azure.com
330330
token: ${AZURE_TOKEN}
331331
organization: ${AZURE_ORG}
332-
- package: ./dynamic-plugins/dist/backstage-plugin-azure-devops
332+
- package: ./dynamic-plugins/dist/backstage-community-plugin-azure-devops
333333
disabled: true
334334
pluginConfig:
335335
dynamicPlugins:
336336
frontend:
337-
backstage.plugin-azure-devops:
337+
backstage-community.plugin-azure-devops:
338338
mountPoints:
339339
- mountPoint: entity.page.ci/cards
340340
importName: EntityAzurePipelinesContent
@@ -352,11 +352,11 @@ plugins:
352352
if:
353353
allOf:
354354
- isAzureDevOpsAvailable
355-
- package: ./dynamic-plugins/dist/parfuemerie-douglas-scaffolder-backend-module-azure-repositories
355+
- package: ./dynamic-plugins/dist/parfuemerie-douglas-scaffolder-backend-module-azure-repositories-dynamic
356356
disabled: true
357357

358358
# Group: Jenkins
359-
- package: ./dynamic-plugins/dist/backstage-plugin-jenkins-backend-dynamic
359+
- package: ./dynamic-plugins/dist/backstage-community-plugin-jenkins-backend-dynamic
360360
disabled: true
361361
pluginConfig:
362362
jenkins:
@@ -365,12 +365,12 @@ plugins:
365365
baseUrl: ${JENKINS_URL}
366366
username: ${JENKINS_USERNAME}
367367
apiKey: ${JENKINS_TOKEN}
368-
- package: ./dynamic-plugins/dist/backstage-plugin-jenkins
368+
- package: ./dynamic-plugins/dist/backstage-community-plugin-jenkins
369369
disabled: true
370370
pluginConfig:
371371
dynamicPlugins:
372372
frontend:
373-
backstage.plugin-jenkins:
373+
backstage-community.plugin-jenkins:
374374
mountPoints:
375375
- mountPoint: entity.page.ci/cards
376376
importName: EntityJenkinsContent
@@ -382,18 +382,18 @@ plugins:
382382
- isJenkinsAvailable
383383

384384
# Group: SonarQube
385-
- package: ./dynamic-plugins/dist/backstage-plugin-sonarqube-backend-dynamic
385+
- package: ./dynamic-plugins/dist/backstage-community-plugin-sonarqube-backend-dynamic
386386
disabled: true
387387
pluginConfig:
388388
sonarqube:
389389
baseUrl: ${SONARQUBE_URL}
390390
apiKey: ${SONARQUBE_TOKEN}
391-
- package: ./dynamic-plugins/dist/backstage-plugin-sonarqube
391+
- package: ./dynamic-plugins/dist/backstage-community-plugin-sonarqube
392392
disabled: true
393393
pluginConfig:
394394
dynamicPlugins:
395395
frontend:
396-
backstage.plugin-sonarqube:
396+
backstage-community.plugin-sonarqube:
397397
mountPoints:
398398
- mountPoint: entity.page.overview/cards
399399
importName: EntitySonarQubeCard
@@ -700,12 +700,12 @@ plugins:
700700
timeout:
701701
minutes: 3
702702

703-
- package: ./dynamic-plugins/dist/backstage-plugin-dynatrace
703+
- package: ./dynamic-plugins/dist/backstage-community-plugin-dynatrace
704704
disabled: true
705705
pluginConfig:
706706
dynamicPlugins:
707707
frontend:
708-
backstage.plugin-dynatrace:
708+
backstage-community.plugin-dynatrace:
709709
mountPoints:
710710
- mountPoint: entity.page.monitoring/cards
711711
importName: DynatraceTab
@@ -828,12 +828,12 @@ plugins:
828828
anyOf:
829829
- isJfrogArtifactoryAvailable
830830

831-
- package: ./dynamic-plugins/dist/backstage-plugin-lighthouse
831+
- package: ./dynamic-plugins/dist/backstage-community-plugin-lighthouse
832832
disabled: true
833833
pluginConfig:
834834
dynamicPlugins:
835835
frontend:
836-
backstage.plugin-lighthouse:
836+
backstage-community.plugin-lighthouse:
837837
appIcons:
838838
- name: lighthouse
839839
importName: LighthouseIcon
@@ -855,12 +855,12 @@ plugins:
855855
allOf:
856856
- isLighthouseAvailable
857857

858-
- package: ./dynamic-plugins/dist/backstage-plugin-tech-radar
858+
- package: ./dynamic-plugins/dist/backstage-community-plugin-tech-radar
859859
disabled: true
860860
pluginConfig:
861861
dynamicPlugins:
862862
frontend:
863-
backstage.plugin-tech-radar:
863+
backstage-community.plugin-tech-radar:
864864
apiFactories:
865865
- importName: TechRadarApi
866866
appIcons:
@@ -908,9 +908,6 @@ plugins:
908908
providers:
909909
microsoftGraphOrg: {}
910910

911-
- package: ./dynamic-plugins/dist/backstage-plugin-catalog-backend-module-logs-dynamic
912-
disabled: true
913-
914911
- package: ./dynamic-plugins/dist/backstage-plugin-catalog-backend-module-ldap-dynamic
915912
disabled: true
916913
pluginConfig:

dynamic-plugins/_utils/package.json

+5-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
},
99
"scripts": {
1010
"copy-dynamic-plugins": "node ./copy-plugins.js",
11-
"lint": "backstage-cli package lint"
11+
"lint": "backstage-cli package lint",
12+
"test:wrappers": "backstage-cli package test --passWithNoTests --coverage"
1213
},
1314
"devDependencies": {
14-
"@backstage/cli": "0.28.2"
15+
"@backstage/cli": "0.28.2",
16+
"glob": "11.0.0",
17+
"yaml": "2.6.0"
1518
}
1619
}

0 commit comments

Comments
 (0)