Skip to content

Commit 1d506ba

Browse files
Replace names of startup metrics with the new names
1 parent f6d608c commit 1d506ba

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

dashboard/new-dashboard/src/components/startup/IntelliJPulse.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
title=""
9696
/>
9797
<LineChart
98-
:measures="['metrics.codeAnalysisDaemon/fusExecutionTime', 'metrics.runDaemon/executionTime']"
98+
:measures="['metrics.fus_daemon_finished_full_duration_since_started_ms', 'metrics.runDaemon/executionTime']"
9999
:configurators="configurators"
100100
title=""
101101
tooltip-trigger="axis"

dashboard/new-dashboard/src/shared/metricsDescription.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ export const metricsDescription: Map<string, string | MetricInfo> = new Map<stri
1919
// FUS events (some of them used for (mega)APDEX calculations)
2020
["fus_file_types_usage_duration_ms", 'FUS event with groupID="file.types.usage" eventID="open" eventField="duration_ms", (mega)APDEX: "File Openings: Code Loaded"'],
2121
["fus_file_types_usage_time_to_show_ms", 'FUS event with groupID="file.types.usage" eventID="open" eventField="time_to_show", (mega)APDEX: "File Openings: Tab Shown"'],
22-
["fus_daemon_finished_full_duration_since_started_ms", 'FUS event with groupID="daemon" eventID="finished" eventField="full_duration_since_started_ms"'],
22+
[
23+
"fus_daemon_finished_full_duration_since_started_ms",
24+
'FUS event with groupID="daemon" eventID="finished" eventField="full_duration_since_started_ms. Full highlighting duration since the file was modified and/or dumb mode status changed. It should be equal to the sum of segments."',
25+
],
2326
["fus_completion_duration_sum", 'SUM of FUS events with groupID="completion" eventID="finished" eventField="duration"'],
2427
["fus_completion_duration_90p", '90 percentile of FUS events with groupID="completion" eventID="finished" eventField="duration"'],
2528
["fus_time_to_show_90p", '90 percentile of FUS events with groupID="completion" eventID="finished" eventField="time_to_show"'],
@@ -29,14 +32,14 @@ export const metricsDescription: Map<string, string | MetricInfo> = new Map<stri
2932
["fus_git_branches_vfs_refresh", 'FUS event with groupID="git.branches" eventID="checkout.vfs_refresh.finished" eventField="duration_ms"'],
3033
["fus_vcs_commit_duration", 'FUS event with groupID="vcs" eventID="commit.finished" eventField="duration_ms"'],
3134
["fus_find_usages_all", 'FUS event with groupID="usage.view" eventID="finished" eventField="duration_ms"'],
32-
["fus_find_usages_first", 'FUS event with groupID="usage.view" eventID="finished" eventField="duration_first_results_ms"'],
35+
["fus_find_usages_first", 'FUS event with groupID="usage.view" eventID="finished" eventField="duration_first_results_ms. Old startup metric"'],
3336
["fus_startup_totalDuration", 'FUS event with groupID="startup" eventID="totalDuration" eventField="duration"'],
3437
["fus_reopen_startup_frame_became_interactive", 'FUS event with groupID="reopen.project.startup.performance" eventID="frame.became.interactive" eventField="duration_ms"'],
3538
["fus_reopen_startup_first_ui_shown", 'FUS event with groupID="reopen.project.startup.performance" eventID="first.ui.shown" eventField="duration_ms"'],
3639
["fus_reopen_startup_frame_became_visible", 'FUS event with groupID="reopen.project.startup.performance" eventID="frame.became.visible" eventField="duration_ms"'],
3740
[
3841
"fus_reopen_startup_code_loaded_and_visible_in_editor",
39-
'FUS event with groupID="reopen.project.startup.performance" eventID="code.loaded.and.visible.in.editor" eventField="duration_ms"',
42+
'FUS event with groupID="reopen.project.startup.performance" eventID="code.loaded.and.visible.in.editor" eventField="duration_ms. New main metric for startup"',
4043
],
4144
[
4245
"fus_gradle.sync",
@@ -60,7 +63,6 @@ export const metricsDescription: Map<string, string | MetricInfo> = new Map<stri
6063
["localInspections", "Sum time of all analysis. From Daemon#restart till DaemonListener#daemonFinished."],
6164
["localInspections#mean_value", "Code analysis mean time. From Daemon#restart till DaemonListener#daemonFinished."],
6265
["runDaemon/executionTime", "Time it takes to complete a first daemon run. It might be restarted so it's not a full time."],
63-
["codeAnalysisDaemon/fusExecutionTime", "Full highlighting duration since the file was modified and/or dumb mode status changed. It should be equal to the sum of segments."],
6466
["globalInspections", "Time of all inspections runned in batch mode (Inspect Project)."],
6567
//indexing
6668
["indexSize", "Index size in (in kb)"],
@@ -75,9 +77,6 @@ export const metricsDescription: Map<string, string | MetricInfo> = new Map<stri
7577
"pageHit",
7678
"CPU attempts to obtain a needed page from main memory and the page exists in main memory (RAM), it is referred to as a PAGE HIT. This metric displays the number of successful Pages' obtainment.",
7779
],
78-
// startup
79-
["reopenProjectPerformance/fusCodeVisibleInEditorDurationMs", metricInfo("New main metric for startup", "https://youtrack.jetbrains.com/articles/IJPL-A-286/Startup-Metric")],
80-
["startup/fusTotalDuration", metricInfo("Old metric (outdated)", "https://youtrack.jetbrains.com/articles/IJPL-A-286/Startup-Metric")],
8180
//typing
8281
["typing", "Typing executing time (usually equal to number of typed characters times delay between key presses)"],
8382
["typing#average_awt_delay", "How long on average it takes to process a single empty AWT event in the queue during typing."],

pkg/degradation-detector/setting/golandSettings.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func GenerateStartupSettingsForGoland(backendUrl string, client *http.Client) []
2525
slog.Error("error while getting projects", "error", err)
2626
return settings
2727
}
28-
metrics := []string{"startup/fusTotalDuration", "progressMetric/Progress: Updating Go modules dependencies", "metrics.progressMetric/Progress: Updating Go modules dependencies#mean_value"}
28+
metrics := []string{"fus_startup_totalDuration", "progressMetric/Progress: Updating Go modules dependencies", "metrics.progressMetric/Progress: Updating Go modules dependencies#mean_value"}
2929
for _, project := range projects {
3030
for _, metric := range metrics {
3131
settings = append(settings, detector.StartupSettings{

pkg/degradation-detector/setting/startupSettings.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func GenerateStartupSettingsForIDEA(backendUrl string, client *http.Client) []de
2929
metrics := []string{
3030
"appInit_d", "app initialization.end", "bootstrap_d",
3131
"classLoadingLoadedCount", "classLoadingPreparedCount", "editorRestoring",
32-
"codeAnalysisDaemon/fusExecutionTime", "runDaemon/executionTime", "startup/fusTotalDuration", "exitMetrics/application.exit",
32+
"fus_daemon_finished_full_duration_since_started_ms", "runDaemon/executionTime", "fus_startup_totalDuration", "exitMetrics/application.exit", "fus_reopen_startup_code_loaded_and_visible_in_editor",
3333
}
3434
for _, machine := range machines {
3535
for _, project := range projects {

0 commit comments

Comments
 (0)