[kotlin] KTIJ-35987 get rid of stub access when creating script module

Merge-request: IJ-MR-178696
Merged-by: Vlad Koshkin <[email protected]>

GitOrigin-RevId: 2988648f1de09e8306fbf667d4fd6af4de2c7c4f

Author: imbananko

plugins/kotlin/base/fir/scripting/src/org/jetbrains/kotlin/base/fir/scripting/projectStructure/FirKaScriptingModuleFactory.kt

@@ -9,21 +9,29 @@ import org.jetbrains.kotlin.analysis.api.projectStructure.KaModule
 import org.jetbrains.kotlin.base.fir.scripting.projectStructure.modules.KaScriptDependencyLibraryModuleImpl
 import org.jetbrains.kotlin.base.fir.scripting.projectStructure.modules.KaScriptModuleImpl
 import org.jetbrains.kotlin.idea.KotlinFileType
-import org.jetbrains.kotlin.idea.core.script.k2.modules.KotlinScriptLibraryEntity
 import org.jetbrains.kotlin.idea.base.fir.projectStructure.FirKaModuleFactory
+import org.jetbrains.kotlin.idea.core.script.k2.modules.KotlinScriptLibraryEntity
 import org.jetbrains.kotlin.psi.KtFile
+import org.jetbrains.kotlin.scripting.definitions.isNonScript
 
 internal class FirKaScriptingModuleFactory : FirKaModuleFactory {
     override fun createScriptLibraryModule(
-        project: Project,
-        entity: KotlinScriptLibraryEntity
+        project: Project, entity: KotlinScriptLibraryEntity
     ): KaLibraryModule {
         return KaScriptDependencyLibraryModuleImpl(entity, project)
     }
 
     override fun createKaModuleByPsiFile(file: PsiFile): KaModule? {
         val ktFile = file as? KtFile ?: return null
+
+        /*
+        For compiled scripts we should not create any KaScriptModule
+        as we do not treat them as scripts, a proper module for them
+        should be KaScriptDependencyModule. */
+        if (ktFile.isCompiled) return null
+
         if (file.virtualFile is VirtualFileWindow) return null
+        if (file.virtualFile.isNonScript()) return null
 
         if (file.virtualFile.extension == KotlinFileType.EXTENSION) {
             /*
@@ -37,23 +45,6 @@ internal class FirKaScriptingModuleFactory : FirKaModuleFactory {
             return null
         }
 
-        return when {
-            !ktFile.isScript() -> {
-                null
-            }
-            ktFile.isCompiled -> {
-                /*
-                For compiled scripts we should not create any KaScriptModule
-                as we do not treat them as scripts, a proper module for them
-                should be KaScriptDependencyModule.
-                */
-                null
-            }
-            else -> {
-                val virtualFile = file.originalFile.virtualFile
-
-                KaScriptModuleImpl(file.project, virtualFile)
-            }
-        }
+        return KaScriptModuleImpl(file.project, file.originalFile.virtualFile)
     }
 }