[JEWEL-1018] Speed Searchable ComboBox #3250
Closed
+652
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
requested review from
daaria-s,
jakub-senohrabek,
nebojsa-vuksic and
rock3r
faogustavo
force-pushed
the
gv/JEWEL-1018
branch
3 times, most recently
from
6e7f518 to
f6e24ba
Compare
rock3r
approved these changes
Sep 29, 2025
|
Would it make sense to instead just add argument "searchable" to the original ListComboBox? |
|
@jakub-senohrabek not really, because it's not something that can be done just with a boolean flag, if you look at the implementation |
nebojsa-vuksic
approved these changes
Oct 16, 2025
.../jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/search/SpeedSearchableComboBox.kt
Outdated
Show resolved
Hide resolved
jakub-senohrabek
approved these changes
Oct 16, 2025
vprotasov
suggested changes
Oct 16, 2025
...tests/src/test/kotlin/org/jetbrains/jewel/ui/component/search/SpeedSearchableComboBoxTest.kt
Outdated
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-1018
branch
from
f6e24ba to
8ab98f0
Compare
faogustavo
force-pushed
the
gv/JEWEL-1018
branch
from
8ab98f0 to
13c6336
Compare
|
Ready to merge |
- Created new component supporting String-based and Generic-based APIs - Added support to choose SpeedSearch input position to support showing in the opposite size of the drop down
faogustavo
force-pushed
the
gv/JEWEL-1018
branch
from
13c6336 to
5d4f71e
Compare
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
- Created new component supporting String-based and Generic-based APIs - Added support to choose SpeedSearch input position to support showing in the opposite size of the drop down closes #3250 (cherry picked from commit 126323a67ee7d0e830c8b9d628ab104894c517cc) (cherry picked from commit 9fc61b0e91cd69c67028c8de8015089afd5bcec4) IJ-MR-179919 GitOrigin-RevId: 355cb2e028dad1ea8d05a74c5ff4dcf4e7987c20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
positionto SpeedSearchState so we can show it in the oposite side of the dropdownindexparameter to theitemContentto perform scrolling to the selected itemEvidences
Screen.Recording.2025-09-24.at.16.26.55.mov
Screen.Recording.2025-09-24.at.11.07.18.mov
Release notes
New features
SpeedSearchableComboBoxcomponent that supports speed searchSpeedSearchAreaand has a similar syntax to a normal ComboBox