CLI: minor, simplify K1 entrypoint used only from tests

Author: udalov

compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/KotlinToJVMBytecodeCompiler.kt

@@ -21,6 +21,7 @@ import org.jetbrains.kotlin.cli.common.config.addKotlinSourceRoot
 import org.jetbrains.kotlin.cli.common.fir.FirDiagnosticsCompilerResultsReporter
 import org.jetbrains.kotlin.cli.common.messages.AnalyzerWithCompilerReport
 import org.jetbrains.kotlin.cli.common.messages.MessageCollector
+import org.jetbrains.kotlin.cli.common.modules.ModuleBuilder
 import org.jetbrains.kotlin.cli.common.perfManager
 import org.jetbrains.kotlin.cli.jvm.config.*
 import org.jetbrains.kotlin.cli.jvm.config.ClassicFrontendSpecificJvmConfigurationKeys.JAVA_CLASSES_TRACKER
@@ -199,19 +200,8 @@ object KotlinToJVMBytecodeCompiler {
     )
 
     fun compileBunchOfSources(environment: KotlinCoreEnvironment): Boolean {
-        val moduleVisibilityManager = ModuleVisibilityManager.SERVICE.getInstance(environment.project)
-
-        val friendPaths = environment.configuration.getList(JVMConfigurationKeys.FRIEND_PATHS)
-        for (path in friendPaths) {
-            moduleVisibilityManager.addFriendPath(path)
-        }
-
-        if (!checkKotlinPackageUsageForPsi(environment.configuration, environment.getSourceFiles())) return false
-
-        val generationState = analyzeAndGenerate(environment) ?: return false
-
-        writeOutput(environment.configuration, generationState.factory, null)
-        return true
+        val module = ModuleBuilder("test", environment.configuration.outputDirectory!!.path, "test")
+        return compileModules(environment, buildFile = null, listOf(module))
     }
 
     private fun repeatAnalysisIfNeeded(result: AnalysisResult?, environment: KotlinCoreEnvironment): AnalysisResult? {
@@ -253,7 +243,7 @@ object KotlinToJVMBytecodeCompiler {
         return result
     }
 
-    @Suppress("MemberVisibilityCanBePrivate") // Used in ExecuteKotlinScriptMojo
+    @Suppress("unused") // Used in ExecuteKotlinScriptMojo. To be removed (KT-71729).
     fun analyzeAndGenerate(environment: KotlinCoreEnvironment): GenerationState? {
         val result = environment.configuration.perfManager.let {
             it?.notifyPhaseFinished(PhaseType.Initialization)

compiler/cli/src/org/jetbrains/kotlin/cli/jvm/compiler/cliCompilerUtils.kt

@@ -68,7 +68,7 @@ fun getBuildFilePaths(buildFile: File?, sourceFilePaths: List<String>): List<Str
         (File(path).takeIf(File::isAbsolute) ?: buildFile.resolveSibling(path)).absolutePath
     }
 
-fun writeOutput(
+private fun writeOutput(
     configuration: CompilerConfiguration,
     outputFiles: OutputFileCollection,
     mainClassFqName: FqName?

compiler/tests-integration/tests/org/jetbrains/kotlin/integration/ColorsTest.kt

@@ -61,8 +61,7 @@ class ColorsTest : TestCaseWithTmpdir() {
 
         val environment = KotlinCoreEnvironment.createForTests(testRootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
 
-        // Compilation should return false, because there's one error.
-        assertFalse(KotlinToJVMBytecodeCompiler.compileBunchOfSources(environment))
+        KotlinToJVMBytecodeCompiler.compileBunchOfSources(environment)
 
         val firstBytes = log.toByteArray().take(7)
         val logStartsWithColors = firstBytes.joinToString(" ") { it.toString(16) } == "1b 5b 31 3b 33 31 6d"