Skip to content

Commit 6dae40a

Browse files
committed
fbmem: fix horribly incorrect placement of __maybe_unused
Commit b9d79e4 ("fbmem: Mark proc_fb_seq_ops as __maybe_unused") places the '__maybe_unused' in an entirely incorrect location between the "struct" keyword and the structure name. It's a wonder that gcc accepts that silently, but clang quite reasonably warns about it: drivers/video/fbdev/core/fbmem.c:736:21: warning: attribute declaration must precede definition [-Wignored-attributes] static const struct __maybe_unused seq_operations proc_fb_seq_ops = { ^ Fix it. Cc: Guenter Roeck <[email protected]> Cc: Daniel Vetter <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent efc58a9 commit 6dae40a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/video/fbdev/core/fbmem.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
733733
return 0;
734734
}
735735

736-
static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
736+
static const struct seq_operations __maybe_unused proc_fb_seq_ops = {
737737
.start = fb_seq_start,
738738
.next = fb_seq_next,
739739
.stop = fb_seq_stop,

0 commit comments

Comments
 (0)