Split src/XML.jl into dedicated files (pure moves, no behavior change)#81
Merged
Conversation
Assisted-by: Claude (Anthropic)
….jl (pure move) Assisted-by: Claude (Anthropic)
Assisted-by: Claude (Anthropic)
…on and REPL show into src/node.jl (pure move)
The satellite reader includes (xpath/lazynode/cursor), which sat mid-file
inside the navigation section, are hoisted next to include("node.jl") —
nothing after them depends on the lazy readers at load time.
Assisted-by: Claude (Anthropic)
Assisted-by: Claude (Anthropic)
The include order is documented as the dependency contract, with a slot reserved for the future flatnode.jl reader (v0.5). dtd.jl joins the manifest block (it had stayed at its original position after extraction). Assisted-by: Claude (Anthropic)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 6 11 +5
Lines 1793 1793
=======================================
Hits 1694 1694
Misses 99 99
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the
src/XML.jlmonolith (1409 lines, 18 banner-delimited sections) into dedicated files, matching the existing satellite style (lazynode.jl/cursor.jl/xpath.jl):escape.jlESCAPE_CHARS+escape/unescapenode.jlNodeType,Attributes,Node, accessors, navigation, equality, indexing, mutation, REPL showwrite.jlXML.writeentry pointsparse.jlBase.readentry points, the parserdtd.jlXML.jlhbuilder, deprecationsEvery extraction is a pure move — one commit per file, the full test suite green at each commit, +5 lines total across
src/(the include statements), zero API or behavior change. The satellite includes that sat mid-file (a historical accident — nothing after them depends on the lazy readers at load time) are hoisted into the manifest, and a slot is reserved for the planned v0.5flatnode.jlreader.