consolidate append=true behavior of MySQL.load#224
Closed
psteinb wants to merge 1 commit into
Closed
Conversation
Contributor
|
We still want to create table at the first time even if append=true. I think maybe it should be like: |
Member
|
Thanks for the contribution! However, this change would be breaking - users who call I'll implement the suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks again for providing and supporting the library.
This is a a suggestion to avoid triggering a warning. If a user calls
MySQL.loadwithappend=true, I think she is likely to assume or know that the table undernamealready exists. Hence callingcreatetableto me doesn't make too much sense. For this, I suggest to put the entire try-catch clasue in the!appendif statement.