Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to latest binding change in 1.12 #681

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

gbaraldi
Copy link
Contributor

We may want to clean this up whenever the binding stuff finally stabilizes

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/validation.jl b/src/validation.jl
index 5af965e..8f73a79 100644
--- a/src/validation.jl
+++ b/src/validation.jl
@@ -239,7 +239,7 @@ function check_ir!(job, errors::Vector{IRError}, inst::LLVM.CallInst)
                 push!(errors, (DELAYED_BINDING, bt, nothing))
             end
         elseif fn == "jl_reresolve_binding_value_seqcst" || fn == "ijl_reresolve_binding_value_seqcst" ||
-               fn == "jl_get_binding_value_seqcst" || fn == "ijl_get_binding_value_seqcst"
+                fn == "jl_get_binding_value_seqcst" || fn == "ijl_get_binding_value_seqcst"
             try
                 # pry the binding from the IR
                 expr = arguments(inst)[1]::ConstantExpr

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.27%. Comparing base (5a14f02) to head (5b8b2f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   65.19%   68.27%   +3.07%     
==========================================
  Files          24       24              
  Lines        3451     3451              
==========================================
+ Hits         2250     2356     +106     
+ Misses       1201     1095     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt merged commit 2944591 into JuliaGPU:master Mar 25, 2025
18 checks passed
@maleadt
Copy link
Member

maleadt commented Mar 25, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants