Skip to content

Commit 9387406

Browse files
authored
Add some comments linking to the PR and the bug report
Thus, future readers of the source code will understand why we use this naming convention. [Applies suggestions from code review.]
1 parent a8ab5c9 commit 9387406

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/PackageCompiler.jl

+8
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,10 @@ function create_fresh_base_sysimage(stdlibs::Vector{String}; cpu_target::String,
226226
base_dir = dirname(sysimg_source_path)
227227
tmp_corecompiler_ji = joinpath(tmp, "corecompiler.ji")
228228
tmp_sys_o = joinpath(tmp, "sys-o.a")
229+
# This naming convention (`sys-o.a`) is necessary to make the sysimage
230+
# work on macOS.
231+
# Bug report: https://github.com/JuliaLang/PackageCompiler.jl/issues/738
232+
# PR: https://github.com/JuliaLang/PackageCompiler.jl/pull/930
229233
tmp_sys_sl = joinpath(tmp, "sys." * Libdl.dlext)
230234

231235
compiler_source_path = joinpath(base_dir, "compiler", "compiler.jl")
@@ -640,6 +644,10 @@ function create_sysimage(packages::Union{Nothing, Symbol, Vector{String}, Vector
640644

641645
# Create the sysimage
642646
object_file = tempname() * "-o.a"
647+
# This naming convention (`-o.a`) is necessary to make the sysimage
648+
# work on macOS.
649+
# Bug report: https://github.com/JuliaLang/PackageCompiler.jl/issues/738
650+
# PR: https://github.com/JuliaLang/PackageCompiler.jl/pull/930
643651

644652
create_sysimg_object_file(object_file, packages, packages_sysimg;
645653
project,

0 commit comments

Comments
 (0)