Various fixes

Author: timholy

src/workloads.jl

@@ -12,13 +12,15 @@ function workload_enabled(mod::Module)
     end
 end
 
-@noinline function precompile_newly_inferred(cis)
+cache_newly_inferred() = ccall(:jl_set_newly_inferred, Cvoid, (Any,), newly_inferred)
+
+@noinline function precompile_newly_inferred()
     ccall(:jl_set_newly_inferred, Cvoid, (Any,), nothing) # ensure we drop internally references to both newly_inferred arrays so that it is safe to access them here
-    for child in cis # set the must-precompile bit on all new code
+    for child in newly_inferred # set the must-precompile bit on all new code
         precompile_mi((child::Base.CodeInstance).def)
     end
-    append!(Base.newly_inferred, cis) # request the new code be included in the serialized file
-    empty!(cis)
+    append!(Base.newly_inferred, newly_inferred) # request the new code be included in the serialized file
+    empty!(newly_inferred)
     nothing
 end
 
@@ -59,13 +61,12 @@ macro compile_workload(ex::Expr)
         end
     end
     ex = quote
-        ccall(:jl_set_newly_inferred, Cvoid, (Any,), newly_inferred)
+        $PrecompileTools.cache_newly_inferred()
         try
             $ex
         finally
-            ccall(:jl_set_newly_inferred, Cvoid, (Any,), nothing)
+            $PrecompileTools.precompile_newly_inferred()
         end
-        $PrecompileTools.precompile_newly_inferred(newly_inferred)
     end
     return quote
         if $iscompiling || $PrecompileTools.verbose[]

test/runtests.jl

@@ -22,7 +22,7 @@ using Base: specializations
     for mi in specializations(m)
         mi === nothing && continue
         sig = Base.unwrap_unionall(mi.specTypes)
-        if sig.parameters[2] == PC_A.MyType && sig.parameters[3] == Vector{PC_A.MyType}
+        if sig == Tuple{typeof(PC_A.call_findfirst), PC_A.MyType, Vector{PC_A.MyType}}
             count += 1
         end
     end