From 1c84a69f2af04d91a825adbd44538d4b4e72114c Mon Sep 17 00:00:00 2001 From: Hossein Pourbozorg Date: Fri, 24 May 2024 20:15:04 +0330 Subject: [PATCH 1/2] Simplify `workload_enabled` --- src/workloads.jl | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/workloads.jl b/src/workloads.jl index 373c3af..43e4840 100644 --- a/src/workloads.jl +++ b/src/workloads.jl @@ -1,14 +1,6 @@ function workload_enabled(mod::Module) - try - if load_preference(@__MODULE__, "precompile_workloads", true) - return load_preference(mod, "precompile_workload", true) - else - return false - end - catch - true - end + load_preference(@__MODULE__, "precompile_workloads", true) && load_preference(mod, "precompile_workload", true) end """ @@ -81,7 +73,8 @@ macro compile_workload(ex::Expr) else # Use the hack on earlier Julia versions that blocks the interpreter ex = quote - while false end + while false + end $(esc(ex)) end end From 9de514333fb108ca8298d55acefa49d7635e7d7f Mon Sep 17 00:00:00 2001 From: Hossein Pourbozorg Date: Sat, 25 May 2024 17:18:18 +0330 Subject: [PATCH 2/2] add a catch with warning --- src/workloads.jl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/workloads.jl b/src/workloads.jl index 43e4840..aaf5104 100644 --- a/src/workloads.jl +++ b/src/workloads.jl @@ -1,6 +1,11 @@ function workload_enabled(mod::Module) - load_preference(@__MODULE__, "precompile_workloads", true) && load_preference(mod, "precompile_workload", true) + try + load_preference(@__MODULE__, "precompile_workloads", true) && load_preference(mod, "precompile_workload", true) + catch + @warn "Preference for the module $mod can't be loaded. passing by default value (true)" + true + end end """