Skip to content

Commit 5f9ef77

Browse files
nalimilanararslan
authored andcommitted
Add instruction to release-candidate target about testing builds without Internet
It is generally a good idea to test that final tarballs build and pass the tests. Disabling Internet access allows ensuring that builds are reproducible, and is necessary for some build servers. Ref #24496 (cherry picked from commit 8cb3701)
1 parent 7854867 commit 5f9ef77

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

Makefile

+6-5
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,12 @@ release-candidate: release testall
154154
@echo 5. Create tag, push to github "\(git tag v\`cat VERSION\` && git push --tags\)" #"` # These comments deal with incompetent syntax highlighting rules
155155
@echo 6. Clean out old .tar.gz files living in deps/, "\`git clean -fdx\`" seems to work #"`
156156
@echo 7. Replace github release tarball with tarballs created from make light-source-dist and make full-source-dist
157-
@echo 8. Follow packaging instructions in DISTRIBUTING.md to create binary packages for all platforms
158-
@echo 9. Upload to AWS, update https://julialang.org/downloads and http://status.julialang.org/stable links
159-
@echo 10. Update checksums on AWS for tarball and packaged binaries
160-
@echo 11. Announce on mailing lists
161-
@echo 12. Change master to release-0.X in base/version.jl and base/version_git.sh as in 4cb1e20
157+
@echo 8. Check that 'make && make install && make test' succeed with unpacked tarballs even without Internet access.
158+
@echo 9. Follow packaging instructions in DISTRIBUTING.md to create binary packages for all platforms
159+
@echo 10. Upload to AWS, update https://julialang.org/downloads and http://status.julialang.org/stable links
160+
@echo 11. Update checksums on AWS for tarball and packaged binaries
161+
@echo 12. Announce on mailing lists
162+
@echo 13. Change master to release-0.X in base/version.jl and base/version_git.sh as in 4cb1e20
162163
@echo
163164

164165
$(build_man1dir)/julia.1: $(JULIAHOME)/doc/man/julia.1 | $(build_man1dir)

0 commit comments

Comments
 (0)