Skip to content

Commit 60683a3

Browse files
committed
precompile: fix deps list for extensions relying on stdlibs
Some packages add extensions to stdlibs, so we should not have prohibited precompiling those. This broke Compat, which adds an extension to LinearAlgebra.
1 parent ec5cf08 commit 60683a3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

base/precompilation.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,9 +1033,8 @@ function _precompilepkgs(pkgs::Union{Vector{String}, Vector{PkgId}},
10331033
if interrupted_or_done[]
10341034
return
10351035
end
1036-
# for extensions, any extension in our direct dependencies is one we have a right to load
1037-
# for packages, we may load any extension (all possible triggers are accounted for above)
1038-
loadable_exts = haskey(ext_to_parent, pkg) ? filter((dep)->haskey(ext_to_parent, dep), direct_deps[pkg]) : nothing
1036+
# for extensions, any extension that can trigger it needs to be accounted for here (even stdlibs, which are excluded from direct_deps)
1037+
loadable_exts = haskey(ext_to_parent, pkg) ? filter((dep)->haskey(ext_to_parent, dep), triggers[pkg]) : nothing
10391038
if _from_loading && pkg in requested_pkgids
10401039
# loading already took the cachefile_lock and printed logmsg for its explicit requests
10411040
t = @elapsed ret = begin

0 commit comments

Comments
 (0)