Revert "More fixes for non-1 arrays"

This reverts commit 39cd805.

Author: tkelman

base/abstractarray.jl

@@ -125,7 +125,7 @@ julia> length(A)
 length(t::AbstractArray) = prod(size(t))
 _length(A::AbstractArray) = prod(map(unsafe_length, indices(A))) # circumvent missing size
 _length(A) = length(A)
-endof(a::AbstractArray) = last(linearindices(a))
+endof(a::AbstractArray) = length(a)
 first(a::AbstractArray) = a[first(eachindex(a))]
 
 function first(itr)

base/array.jl

@@ -690,30 +690,26 @@ function lexcmp(a::Array{UInt8,1}, b::Array{UInt8,1})
     return c < 0 ? -1 : c > 0 ? +1 : cmp(length(a),length(b))
 end
 
-function reverse(A::AbstractVector, s=first(linearindices(A)), n=last(linearindices(A)))
+function reverse(A::AbstractVector, s=1, n=length(A))
     B = similar(A)
-    for i = first(linearindices(A)):s-1
+    for i = 1:s-1
         B[i] = A[i]
     end
     for i = s:n
         B[i] = A[n+s-i]
     end
-    for i = n+1:last(linearindices(A))
+    for i = n+1:length(A)
         B[i] = A[i]
     end
     return B
 end
-function reverseind(a::AbstractVector, i::Integer)
-    li = linearindices(a)
-    first(li) + last(li) - i
-end
+reverseind(a::AbstractVector, i::Integer) = length(a) + 1 - i
 
-function reverse!(v::AbstractVector, s=first(linearindices(v)), n=last(linearindices(v)))
-    liv = linearindices(v)
+function reverse!(v::AbstractVector, s=1, n=length(v))
     if n <= s  # empty case; ok
-    elseif !(first(liv) ≤ s ≤ last(liv))
+    elseif !(1 ≤ s ≤ endof(v))
         throw(BoundsError(v, s))
-    elseif !(first(liv) ≤ n ≤ last(liv))
+    elseif !(1 ≤ n ≤ endof(v))
         throw(BoundsError(v, n))
     end
     r = n

test/offsetarray.jl

@@ -268,19 +268,9 @@ am = map(identity, a)
 
 # other functions
 v = OffsetArray(v0, (-3,))
-@test endof(v) == 1
 @test_approx_eq v v
 @test parent(v') == v0'
 @test indices(v') === (1:1,-2:1)
-rv = reverse(v)
-@test indices(rv) == indices(v)
-@test rv[1] == v[-2]
-@test rv[0] == v[-1]
-@test rv[-1] == v[0]
-@test rv[-2] == v[1]
-cv = copy(v)
-@test reverse!(cv) == rv
-
 A = OffsetArray(rand(4,4), (-3,5))
 @test_approx_eq A A
 @test maximum(A) == maximum(parent(A))