speed up serialize_testset_result_file

Author: IanButterworth

test/buildkitetestjson.jl

@@ -104,6 +104,16 @@ function generalize_file_paths(path::AbstractString)
     end
 end
 
+# raw_file_path,line => file,location
+location_cache = Dict{Tuple{Symbol,Int},Tuple{String,String}}()
+function get_location(file::Symbol, line::Int)
+    return get!(location_cache, (file, line)) do
+        _file = generalize_file_paths(string(file))
+        _location = string(_file, ":", line)
+        return _file, _location
+    end
+end
+
 # passed, failed, skipped, or unknown
 function get_status(result)
     if result isa Test.Pass && result.test_type === :skipped
@@ -142,12 +152,11 @@ get_rid(rdata) = (rdata["location"], rdata["result"], haskey(rdata, "failure_exp
 
 function result_dict(result::Test.Result, result_counts::Dict{Tuple{String,String,UInt64},Int})
     file, line = if !hasproperty(result, :source) || isnothing(result.source)
-        "unknown", 0
+        :unknown, 0
     else
-        something(result.source.file, "unknown"), result.source.line
+        something(result.source.file, :unknown), result.source.line
     end
-    file = generalize_file_paths(string(file))
-    location = string(file, ':', line)
+    file, location = get_location(file, line)
     status = get_status(result)
 
     # Early exit for passed tests before more expensive operations