codegen (stubs): report success when registering @ccallable (#57200)

topolarity · web-flow · commit 9777a33824c1 · 2025-01-30T07:55:51.000-05:00
This is required to be able to load a sysimage with ccallable
entrypoints without `libjulia-codegen.so`
diff --git a/src/codegen-stubs.c b/src/codegen-stubs.c
@@ -73,7 +73,10 @@ JL_DLLEXPORT uint32_t jl_get_LLVM_VERSION_fallback(void)
 
 JL_DLLEXPORT int jl_compile_extern_c_fallback(LLVMOrcThreadSafeModuleRef llvmmod, void *params, void *sysimg, jl_value_t *declrt, jl_value_t *sigt)
 {
-    return 0;
+    // Assume we were able to register the ccallable with the JIT. The
+    // fact that we didn't is not observable since we cannot compile
+    // anything else.
+    return 1;
 }
 
 JL_DLLEXPORT void jl_teardown_codegen_fallback(void) JL_NOTSAFEPOINT

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,10 @@ JL_DLLEXPORT uint32_t jl_get_LLVM_VERSION_fallback(void)`
`73`	`73`
`74`	`74`	`JL_DLLEXPORT int jl_compile_extern_c_fallback(LLVMOrcThreadSafeModuleRef llvmmod, void params, void sysimg, jl_value_t declrt, jl_value_t sigt)`
`75`	`75`	`{`
`76`		`- return 0;`
	`76`	`+ // Assume we were able to register the ccallable with the JIT. The`
	`77`	`+ // fact that we didn't is not observable since we cannot compile`
	`78`	`+ // anything else.`
	`79`	`+ return 1;`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`JL_DLLEXPORT void jl_teardown_codegen_fallback(void) JL_NOTSAFEPOINT`