Skip to content

Commit eb603b4

Browse files
make all tests 1s so buildkite doesn't think they're skipped
1 parent 2dc3db9 commit eb603b4

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/buildkitetestjson.jl

+4-3
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ function result_dict(testset::Test.DefaultTestSet, prefix::String="")
7272
"julia_version" => string(VERSION),
7373
"testset" => testset.description,
7474
),
75-
# note we drop some of this from common_data before merging into individual results
7675
"history" => if !isnothing(testset.time_end)
7776
Dict{String,Any}(
7877
"start_at" => testset.time_start,
@@ -177,8 +176,10 @@ end
177176
function collect_results!(results::Vector{Dict{String,Any}}, testset::Test.DefaultTestSet, prefix::String="")
178177
common_data = result_dict(testset, prefix)
179178
# testset duration is not relevant for individual test results
180-
common_data["history"]["duration"] = 0.0 # required field
181-
delete!(common_data["history"], "end_at")
179+
# but buildkite considers zero duration tests to have been skipped, so set all tests to 1.0s
180+
# TODO: get buildkite to support zero duration tests
181+
common_data["history"]["duration"] = 1.0 # required field
182+
common_data["history"]["end_at"] = common_data["history"]["start_at"] + 1
182183
result_offset = length(results) + 1
183184
result_counts = Dict{Tuple{String,String,UInt64},Int}()
184185
get_rid(rdata) = (rdata["location"], rdata["result"], haskey(rdata, "failure_expanded") ? hash(rdata["failure_expanded"]) : UInt64(0))

0 commit comments

Comments
 (0)