Skip to content

No cov(::AbstractMatrix, ::Bool) method #19471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nalimilan opened this issue Dec 1, 2016 · 3 comments
Closed

No cov(::AbstractMatrix, ::Bool) method #19471

nalimilan opened this issue Dec 1, 2016 · 3 comments

Comments

@nalimilan
Copy link
Member

Currently cov(x, false) fails when x is a matrix rather than a vector: you need to use cov(x, 1, false). This is annoying since 1) the docstring appears to imply the both arguments are optional, and 2) it makes it harder to find the replacement for the deprecated cov(x, corrected=false) method.

Is this just an oversight?

Cf. https://discourse.julialang.org/t/what-is-the-current-best-practice-for-population-formula-for-cov/658

@andreasnoack
Copy link
Member

There might be some cleanup left after the removal of the keyword arguments. However, we should think of this with #19451 in mind. We have very few functions left that defaults to dim=1 so we should consider deprecating the cov(Matrix) method.

@nalimilan
Copy link
Member Author

Right. Maybe the best thing to do is improving the deprecation warning.

@nalimilan nalimilan changed the title Not cov(::AbstractMatrix, ::Bool) method No cov(::AbstractMatrix, ::Bool) method Dec 2, 2016
@nalimilan
Copy link
Member Author

cov now takes a corrected keyword argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants