[REPL] Autocompletion of arguments inside ModuleName.function call is broken
#55420
Labels
bisect wanted
bug
Indicates an unexpected problem or unintended behavior
completions
Tab and autocompletion in the repl
regression
Regression in behavior compared to a previous version
REPL
Julia's REPL (Read Eval Print Loop)
Milestone
Comments
giordano
added
bug
giordano
added
the
regression
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 14, 2025
…JuliaLang#57307, JuliaLang#57624 Also fix test failing for silly reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On f0a2a7a, autocompletion of the arguments inside function calls of the form
Module.functionis broken, only keywords are suggested, not types, variables, functions, etc. For example:directly autocompletes to
because
primitive typeis the only keyword starting withp. This is a regression, autocompletion in this situation used to work in previous versions.The text was updated successfully, but these errors were encountered: