-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REPL] Autocompletion broken for macro names if there's other text after it #55842
Labels
bug
Indicates an unexpected problem or unintended behavior
completions
Tab and autocompletion in the repl
regression
Regression in behavior compared to a previous version
REPL
Julia's REPL (Read Eval Print Loop)
Milestone
Comments
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Feb 26, 2025
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Feb 27, 2025
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 3, 2025
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 4, 2025
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
Don't require a using/import to be on its own line to enter import mode; instead look for partial import expressions and require the cursor be in the range where modules/imported names would go. Fixes JuliaLang#56389 (including the fix for JuliaLang#55842)
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 13, 2025
This commit replaces the heuristic parsing done by REPLCompletions.completions with a new approach that parses the entire input buffer once with JuliaSyntax. In addition to fixing bugs, the more precise parsing should allow for new features in the future. Some features now work in more situations "for free", like dictionary key completion (the expression evaluated to find the keys is now more precise) and method suggestions (arguments beyond the cursor can be used to narrow the list). The tests have been updated to reflect slightly differing behaviour for string and Cmd-string completion: the new code returns a character range encompassing the entire string when completing paths (not observable by the user), and the behaviour of '~'-expansion has be tweaked to be consistent across all places where paths can be completed. Some escaping issues have also been fixed. Fixes: JuliaLang#55420, JuliaLang#55518, JuliaLang#55520, JuliaLang#55842, JuliaLang#56389, JuliaLang#57611
xal-0
added a commit
to xal-0/julia
that referenced
this issue
Mar 14, 2025
…JuliaLang#57307, JuliaLang#57624 Also fix test failing for silly reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Indicates an unexpected problem or unintended behavior
completions
Tab and autocompletion in the repl
regression
Regression in behavior compared to a previous version
REPL
Julia's REPL (Read Eval Print Loop)
On d6fa66f:
or
don't complete at all the macro name if there's something else after the
@
sign. This is a regression compared to all previous versions (v1.0 to v1.11)The text was updated successfully, but these errors were encountered: