Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken packages due to misnamed "invoke_in_world_total" #57748

Open
EmmaJaneBonestell opened this issue Mar 13, 2025 · 1 comment
Open

Broken packages due to misnamed "invoke_in_world_total" #57748

EmmaJaneBonestell opened this issue Mar 13, 2025 · 1 comment

Comments

@EmmaJaneBonestell
Copy link

EmmaJaneBonestell commented Mar 13, 2025

This commit has broken some packages (e.g. Pkg.add("Finch")); it appears to be a mistake that amalgamated _call_in_world_total and invoke_in_world into invoke_in_world_total, though I'm unsure which was intended to be called.

#57532

_apply_pure(x...) = invoke_in_world_total(typemax_UInt, x...)

@vtjnash
Copy link
Member

vtjnash commented Mar 13, 2025

It probably should just be an alias _apply. Since it is a deprecation of internal UB that used to exist for the compiler's internal use to support the UB pure annotation, it doesn't really need to do anything other than not break Revise now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants