Skip to content

Commit 76ca44f

Browse files
authored
[CImPlot3D] Rebuild for CImGuiPack_jll 0.13 (#14507)
This needs a rebuild for compatibility, and also to update the compiler options that can break ABI.
1 parent 1ddf459 commit 76ca44f

2 files changed

Lines changed: 12 additions & 8 deletions

File tree

C/CImPlot3D/build_tarballs.jl

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,25 @@
33
using BinaryBuilder, Pkg
44

55
name = "CImPlot3D"
6-
version = v"0.4.0" # tracking implot3d release tags
6+
# We try to track implot3d release tags, with the occasional patch bump if a
7+
# rebuild is needed for e.g. a new CImGuiPack_jll version.
8+
version = v"0.4.1"
79

810
# Sources required to build CImPlot3D
911
sources = [
1012
# cimplot3d ships the C wrapper; implot3d is its git submodule pinned at a
1113
# SHA that matches the wrapper's generated bindings (currently v0.4 of
1214
# implot3d). A recursive submodule init in the script keeps them locked.
1315
GitSource("https://github.com/cimgui/cimplot3d.git",
14-
"8c1c16e98fdddc4b3ee78bf0f89e0dd708be79e0"),
16+
"8d04820c009357e791e30a004e410c6eb98522d1"),
1517

1618
# cimplot3d's generator does `require"cpp2ffi"` and a `dofile` of cimgui's
17-
# generator output, expecting cimgui as a sibling directory. Pinned to the
18-
# SAME cimgui SHA that CImGuiPack_jll 0.12's libcimgui submodule is built
19-
# from, so the C struct types referenced by the generated cimplot3d.cpp
20-
# match the layout inside libcimgui at runtime.
19+
# generator output, expecting cimgui as a sibling directory. Usually pinned
20+
# to the same cimgui SHA that CImGuiPack_jll's libcimgui submodule is built
21+
# from. Currently one commit ahead to get this patch:
22+
# https://github.com/cimgui/cimgui/pull/326
2123
GitSource("https://github.com/cimgui/cimgui.git",
22-
"1261b231939fc210032f30c4ee8a8f0440372237"),
24+
"700140771a12e61f4bb851fb4e2d885f04b32dd9"),
2325

2426
# Bundled CMakeLists.txt that links against CImGuiPack_jll's exported
2527
# cimgui::cimgui target rather than rebuilding imgui sources locally —
@@ -81,7 +83,7 @@ products = [
8183
]
8284

8385
dependencies = [
84-
Dependency("CImGuiPack_jll"; compat="0.12.1"),
86+
Dependency("CImGuiPack_jll"; compat="0.13.1"),
8587
HostBuildDependency("LuaJIT_jll"),
8688
]
8789

C/CImPlot3D/bundled/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ target_include_directories(cimplot3d PRIVATE
3535
target_compile_definitions(cimplot3d PRIVATE
3636
IMGUI_DISABLE_OBSOLETE_FUNCTIONS=1
3737
IMGUI_ENABLE_TEST_ENGINE
38+
IMGUI_ENABLE_FREETYPE
39+
IMGUI_USE_WCHAR32
3840
)
3941

4042
target_link_libraries(cimplot3d PRIVATE ${CIMGUI_LIBRARY})

0 commit comments

Comments
 (0)