Skip to content

Commit d3b5c22

Browse files
authored
Add depwarns (but do not remove) the managers that are not currently being maintained (SGE, PBS, HTCondor, and Scyld) (#247)
These managers do not currently have a maintainer. So let's add `depwarn`s. If we are able to recruit a maintainer in the future, we can remove the `depwarn` at that time. 1. SGE (via `qsub` or `qrsh`). 2. PBS (via `qsub`). 3. HTCondor (via `condor_submit`). 4. Scyld ClusterWare (via `bpsh`).
1 parent f0647d8 commit d3b5c22

File tree

3 files changed

+37
-0
lines changed

3 files changed

+37
-0
lines changed

src/condor.jl

+9
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,15 @@ function condor_script(portnum::Integer, np::Integer, params::Dict)
5252
end
5353

5454
function launch(manager::HTCManager, params::Dict, instances_arr::Array, c::Condition)
55+
let
56+
mgr_desc = "HTCondor"
57+
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *
58+
"We are currently looking for a new maintainer. " *
59+
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
60+
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
61+
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
62+
Base.depwarn(msg, Symbol(typeof(manager)))
63+
end
5564
try
5665
portnum = rand(8000:9000)
5766
portnum, server = listenany(ip"0.0.0.0", portnum)

src/qsub.jl

+19
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,25 @@ end
2020

2121
function launch(manager::Union{PBSManager, SGEManager, QRSHManager},
2222
params::Dict, instances_arr::Array, c::Condition)
23+
let
24+
if manager isa PBSManager
25+
mgr_desc = "Portable Batch System (PBS)"
26+
elseif manager isa SGEManager
27+
mgr_desc = "Sun Grid Engine (SGE)"
28+
else
29+
# manager isa QRSHManager
30+
#
31+
# `qrsh` is only available for SGE.
32+
# It is not available for OpenPBS.
33+
mgr_desc = "Sun Grid Engine (SGE)"
34+
end
35+
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *
36+
"We are currently looking for a new maintainer. " *
37+
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
38+
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
39+
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
40+
Base.depwarn(msg, Symbol(typeof(manager)))
41+
end
2342
try
2443
dir = params[:dir]
2544
exename = params[:exename]

src/scyld.jl

+9
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,15 @@ struct ScyldManager <: ClusterManager
55
end
66

77
function launch(manager::ScyldManager, params::Dict, instances_arr::Array, c::Condition)
8+
let
9+
manager_description = "Scyld ClusterWare"
10+
msg = "The $(mgr_desc) functionality in ClusterManagers.jl is currently not actively maintained. " *
11+
"We are currently looking for a new maintainer. " *
12+
"If you are an active user of the $(mgr_desc) functionality and are interested in becoming the maintainer, " *
13+
"Please open an issue on the JuliaParallel/ClusterManagers.jl repo: " *
14+
"https://github.com/JuliaParallel/ClusterManagers.jl/issues"
15+
Base.depwarn(msg, Symbol(typeof(manager)))
16+
end
817
try
918
dir = params[:dir]
1019
exename = params[:exename]

0 commit comments

Comments
 (0)