Skip to content

InverseLBFGSOperator for GPU #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tmigot opened this issue Dec 20, 2023 · 5 comments
Open

InverseLBFGSOperator for GPU #306

tmigot opened this issue Dec 20, 2023 · 5 comments
Labels
enhancement GPU

Comments

@tmigot
Copy link
Member

tmigot commented Dec 20, 2023

This operator is used in JSOSolvers https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/blob/5c08163ee594d8f8d7e12a98b14f4ed7cd22424e/src/lbfgs.jl#L87C3-L87C63 but nothing allows GPU computation
@dpo
Copy link
Member

dpo commented Dec 20, 2023

The solution is probably #258, but needs to be revisited.

@amontoison
Copy link
Member

We would like to run lbfgs from JSOSolvers.jl with @michel2323 on GPU.
What is the issue with InverseLBFGSOperator except the type in the workspace?

@dpo
Copy link
Member

dpo commented Jan 29, 2025

Sorry, I don’t understand the question

@amontoison
Copy link
Member

amontoison commented Jan 29, 2025 •
edited
Loading

Sorry I should reformulate my question. Why is it not working on GPU?
Is it only related to the type of the vectors in the workspace (Vector{T}) ?

@amontoison
Copy link
Member

Ok, I investigated, and it requires more than just making the array types generic. :(

We need some GPU kernels because some updates affect only specific coefficients in the vectors.

It's a full day's work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement GPU
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpo @tmigot @amontoison