Fix method ambiguity (#65)

* Add Aqua to test deps and to test import.

* Added method to avoid method ambiguity.
Base.getindex(s::LaTeXString, i::AbstractUnitRange{<:Integer})

* Made version 1.3.1

* Improved coverage

---------

Co-authored-by: Keith Myerscough <[email protected]>

Author: KeithWM

Project.toml

@@ -1,13 +1,14 @@
 name = "LaTeXStrings"
 uuid = "b964fa9f-0449-5b57-a5c2-d3ea65f4040f"
-version = "1.3"
+version = "1.3.1"
 
 [compat]
 julia = "1"
 
 [extras]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["Documenter", "Test"]
+test = ["Aqua", "Documenter", "Test"]

src/LaTeXStrings.jl

@@ -117,6 +117,7 @@ Base.getindex(s::LaTeXString, i::Integer) = getindex(s.s, i)
 Base.getindex(s::LaTeXString, i::Int) = getindex(s.s, i) # for method ambig in Julia 0.6
 Base.getindex(s::LaTeXString, i::UnitRange{Int}) = getindex(s.s, i)
 Base.getindex(s::LaTeXString, i::UnitRange{<:Integer}) = getindex(s.s, i)
+Base.getindex(s::LaTeXString, i::AbstractUnitRange{<:Integer}) = getindex(s.s, i) # for method ambiguity
 Base.getindex(s::LaTeXString, i::AbstractVector{<:Integer}) = getindex(s.s, i)
 Base.getindex(s::LaTeXString, i::AbstractVector{Bool}) = getindex(s.s, i) # for method ambiguity
 Base.codeunit(s::LaTeXString, i::Integer) = codeunit(s.s, i)

test/runtests.jl

@@ -1,4 +1,8 @@
 using LaTeXStrings, Test
+import Aqua
+using Base: OneTo
+
+Aqua.test_all(LaTeXStrings)
 
 tst1 = L"an equation: $\alpha^2$"
 tst1s = String(tst1)
@@ -61,15 +65,23 @@ end
     tst1 = L"an equation: $\alpha^2$"
     tst1s = String(tst1)
 
+    @test firstindex(tst1) == 1
+    @test lastindex(tst1) == length(tst1)
+
     @test tst1[5] == tst1s[5]
     @test tst1[15] == tst1s[15]
 
     idx = [5, 10, 15]
     @test tst1[idx] == tst1s[idx]
 
-    # issue #61
-    idx = rand(Bool, length(tst1))
-    @test_throws ArgumentError tst1[idx]
+    # to test for ambiguities (#61, #65)
+    bool_idx = rand(Bool, length(tst1))
+    @test_throws ArgumentError tst1[bool_idx]
+
+    @test tst1[UInt(5)] == tst1[5]
+    @test tst1[UInt.(idx)] == tst1[idx]
+
+    @test tst1[OneTo(5)] == tst1[1:5]
 end
 
 using Documenter