Update CI to use julia-actions/cache and 1.12 + fixes for 1.12#221
Merged
Conversation
c1b6359 to
30eca3a
Compare
julia-actions/cache and 1.12julia-actions/cache and 1.12 + fixes for 1.12
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to test against Julia 1.12 and fixes compatibility issues identified during testing. The main purpose is to ensure the package remains compatible with the upcoming Julia 1.12 release while modernizing the CI setup.
- Update CI to use
julia-actions/cacheaction and test against Julia 1.12-rc1 - Fix world age issues in the
skipkeyword implementation that caused errors in Julia 1.12 - Update test patterns to accommodate changes in Julia 1.12's output formatting
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/CI.yml | Updates CI to use julia-actions/cache and test Julia 1.12-rc1 instead of 1.11 |
| src/ReTestItems.jl | Fixes world age issues in should_skip function and adds documentation comment |
| test/workers.jl | Updates regex patterns to handle Julia 1.12's thread pool output format |
| test/integrationtests.jl | Updates error message expectations for Julia 1.12 compatibility |
| test/internals.jl | Fixes test setup to use proper project file path and imports should_skip function |
Comments suppressed due to low confidence (1)
.github/workflows/CI.yml:22
- The version '~1.12.0-rc1' may not be a valid Julia version specifier. Consider using 'nightly' or '1.12-rc' instead, as release candidate versions typically use different naming conventions in julia-actions/setup-julia.
- '~1.12.0-rc1'
Member
|
The failing |
Drvi
approved these changes
Aug 5, 2025
Member
Drvi
left a comment
There was a problem hiding this comment.
Thanks! I think we can get the rest of the test passing later on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
julia-actions/cacheand also test against (unreleased) Julia version1.12(close Switch CI to usejulia-actions/cache#207)skipkeyword implementation had world age issueswalkdirassumption (followingwalkdirbehaviour change in v1.12 JuliaLang/julia#59092) and update tests accordinglyProfile.printJuliaLang/julia#54994)This leaves one test still failing on v1.12 (the test
runtests() TestProjectFile.jl)