Skip to content

Update CI to use julia-actions/cache and 1.12 + fixes for 1.12#221

Merged
nickrobinson251 merged 10 commits into
mainfrom
npr-ci-update
Aug 5, 2025
Merged

Update CI to use julia-actions/cache and 1.12 + fixes for 1.12#221
nickrobinson251 merged 10 commits into
mainfrom
npr-ci-update

Conversation

@nickrobinson251
Copy link
Copy Markdown
Member

@nickrobinson251 nickrobinson251 commented Jul 25, 2025

  • Update CI to use julia-actions/cache and also test against (unreleased) Julia version 1.12 (close Switch CI to use julia-actions/cache #207)
    • tests and not yet required to pass on v1.12 (given it's not released yet)
  • Fix one genuine v1.12 issue in the code: skip keyword implementation had world age issues
ERROR: UndefVarError: `##skip#279` not defined in `Main.var"##skip_JET error analysis RAI_CompilationsCache package#278"`
The binding may be too new: running in world age 38585, while current world is 38587.
Stacktrace:
  [1] should_skip(ti::TestItem)
    @ ReTestItems ~/.julia/packages/ReTestItems/SUewn/src/ReTestItems.jl:998
  [2] runtestitem(ti::TestItem, ctx::ReTestItems.TestContext; test_end_expr::Expr, logs::Symbol, verbose_results::Bool, finish_test::Bool, catch_test_error::Bool, failfast::Bool)
    @ ReTestItems ~/.julia/packages/ReTestItems/SUewn/src/ReTestItems.jl:1038

This leaves one test still failing on v1.12 (the test runtests() TestProjectFile.jl)

@nickrobinson251 nickrobinson251 requested a review from Copilot July 25, 2025 15:24

This comment was marked as outdated.

@nickrobinson251 nickrobinson251 changed the title Update CI to use julia-actions/cache and 1.12 Update CI to use julia-actions/cache and 1.12 + fixes for 1.12 Aug 4, 2025
@nickrobinson251 nickrobinson251 requested review from Drvi and Copilot August 4, 2025 13:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI configuration to test against Julia 1.12 and fixes compatibility issues identified during testing. The main purpose is to ensure the package remains compatible with the upcoming Julia 1.12 release while modernizing the CI setup.

  • Update CI to use julia-actions/cache action and test against Julia 1.12-rc1
  • Fix world age issues in the skip keyword implementation that caused errors in Julia 1.12
  • Update test patterns to accommodate changes in Julia 1.12's output formatting

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/CI.yml Updates CI to use julia-actions/cache and test Julia 1.12-rc1 instead of 1.11
src/ReTestItems.jl Fixes world age issues in should_skip function and adds documentation comment
test/workers.jl Updates regex patterns to handle Julia 1.12's thread pool output format
test/integrationtests.jl Updates error message expectations for Julia 1.12 compatibility
test/internals.jl Fixes test setup to use proper project file path and imports should_skip function
Comments suppressed due to low confidence (1)

.github/workflows/CI.yml:22

  • The version '~1.12.0-rc1' may not be a valid Julia version specifier. Consider using 'nightly' or '1.12-rc' instead, as release candidate versions typically use different naming conventions in julia-actions/setup-julia.
          - '~1.12.0-rc1'

@Drvi
Copy link
Copy Markdown
Member

Drvi commented Aug 5, 2025

The failing runtests() TestProjectFile.jl passes with JuliaTesting/TestEnv.jl#98

Copy link
Copy Markdown
Member

@Drvi Drvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can get the rest of the test passing later on

@nickrobinson251 nickrobinson251 merged commit 534810b into main Aug 5, 2025
5 of 9 checks passed
@nickrobinson251 nickrobinson251 deleted the npr-ci-update branch August 5, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch CI to use julia-actions/cache

3 participants