Skip to content

Commit ed1afd4

Browse files
committed
refactor: some naming updates
1 parent 00c1ac0 commit ed1afd4

20 files changed

+32
-30
lines changed

packages/bentocache/drivers/knex.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { KnexAdapter } from '../src/drivers/knex.js'
2-
import { DatabaseStore } from '../src/drivers/database.js'
2+
import { DatabaseDriver } from '../src/drivers/database.js'
33
import type { CreateDriverResult, KnexConfig } from '../src/types/main.js'
44

55
/**
66
* Create a knex driver
77
* You will need to install the underlying database package (mysql2, pg, sqlite3, etc)
88
*/
9-
export function knexDriver(options: KnexConfig): CreateDriverResult<DatabaseStore> {
9+
export function knexDriver(options: KnexConfig): CreateDriverResult<DatabaseDriver> {
1010
return {
1111
options,
1212
factory: (config: KnexConfig) => {
1313
const adapter = new KnexAdapter(config)
14-
return new DatabaseStore(adapter, config)
14+
return new DatabaseDriver(adapter, config)
1515
},
1616
}
1717
}

packages/bentocache/drivers/kysely.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { KyselyAdapter } from '../src/drivers/kysely.js'
2-
import { DatabaseStore } from '../src/drivers/database.js'
2+
import { DatabaseDriver } from '../src/drivers/database.js'
33
import type { CreateDriverResult, KyselyConfig } from '../src/types/main.js'
44

55
/**
66
* Create a kysely driver
77
* You will need to install the underlying database package (mysql2, pg, sqlite3, etc)
88
*/
9-
export function kyselyDriver(options: KyselyConfig): CreateDriverResult<DatabaseStore> {
9+
export function kyselyDriver(options: KyselyConfig): CreateDriverResult<DatabaseDriver> {
1010
return {
1111
options,
1212
factory: (config: KyselyConfig) => {
1313
const adapter = new KyselyAdapter(config)
14-
return new DatabaseStore(adapter, config)
14+
return new DatabaseDriver(adapter, config)
1515
},
1616
}
1717
}

packages/bentocache/src/drivers/database.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import type { DatabaseConfig, CacheDriver, DatabaseAdapter } from '../types/main
66
*
77
* You should provide an adapter that will handle the database interactions
88
*/
9-
export class DatabaseStore extends BaseDriver implements CacheDriver<true> {
9+
export class DatabaseDriver extends BaseDriver implements CacheDriver<true> {
1010
type = 'l2' as const
1111

1212
/**

packages/bentocache/src/drivers/knex.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { Knex } from 'knex'
33
import type { DatabaseAdapter, KnexConfig } from '../types/main.js'
44

55
/**
6-
* Knex adapter for the DatabaseStore
6+
* Knex adapter for the DatabaseDriver
77
*/
88
export class KnexAdapter implements DatabaseAdapter {
99
#connection: Knex

packages/bentocache/src/drivers/kysely.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { SqliteAdapter, type Kysely } from 'kysely'
33
import type { DatabaseAdapter, KyselyConfig } from '../types/main.js'
44

55
/**
6-
* Kysely adapter for the DatabaseStore
6+
* Kysely adapter for the DatabaseDriver
77
*/
88
export class KyselyAdapter implements DatabaseAdapter {
99
#isSqlite: boolean

packages/bentocache/src/types/driver.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export interface CacheDriver<Async extends boolean = true> {
5454
}
5555

5656
/**
57-
* Interface for a DatabaseAdapter that can be used with the DatabaseStore
57+
* Interface for a DatabaseAdapter that can be used with the DatabaseDriver
5858
*/
5959
export interface DatabaseAdapter {
6060
/**

packages/bentocache/test_helpers/driver_test_suite.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import type { CacheDriver, CacheDriverOptions } from '../src/types/main.js'
99
export function registerCacheDriverTestSuite(options: {
1010
test: typeof JapaTest
1111
group: Group
12-
createStore: (options?: CacheDriverOptions) => CacheDriver<any>
12+
createDriver: (options?: CacheDriverOptions) => CacheDriver<any>
1313
configureGroup?: (group: Group) => any
1414

1515
/**
@@ -20,13 +20,15 @@ export function registerCacheDriverTestSuite(options: {
2020
const { test, group } = options
2121
const sleepTime = options.supportsMilliseconds ? 20 : 1000
2222

23-
const cache = options.createStore()
23+
const cache = options.createDriver()
2424

2525
group.tap((t) => t.disableTimeout())
2626
group.each.teardown(async () => {
2727
await cache.clear()
2828
})
2929

30+
options.configureGroup?.(group)
31+
3032
group.teardown(async () => {
3133
await cache.disconnect()
3234
})
@@ -71,7 +73,7 @@ export function registerCacheDriverTestSuite(options: {
7173
})
7274

7375
test('clear() remove only keys with prefix', async ({ assert, cleanup }) => {
74-
const cache2 = options.createStore({ prefix: 'prefix' })
76+
const cache2 = options.createDriver({ prefix: 'prefix' })
7577
cleanup(async () => {
7678
await cache2.clear()
7779
})

packages/bentocache/tests/drivers/database.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { test } from '@japa/runner'
33
import { setTimeout } from 'node:timers/promises'
44

55
import { KnexAdapter } from '../../src/drivers/knex.js'
6-
import { DatabaseStore } from '../../src/drivers/database.js'
6+
import { DatabaseDriver } from '../../src/drivers/database.js'
77

88
test.group('Database', () => {
99
test('should prune expired items every x seconds', async ({ assert, cleanup }) => {
@@ -15,7 +15,7 @@ test.group('Database', () => {
1515
}),
1616
})
1717

18-
const driver = new DatabaseStore(adapter, {
18+
const driver = new DatabaseDriver(adapter, {
1919
tableName: 'cache',
2020
autoCreateTable: true,
2121
pruneInterval: 500,

packages/bentocache/tests/drivers/dynamodb.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async function deleteTable() {
3535
}
3636

3737
test.group('DynamoDB driver', (group) => {
38-
group.each.setup(async () => {
38+
group.setup(async () => {
3939
await createTable().catch((e) => console.error('Could not create table', e))
4040

4141
return async () => {
@@ -47,7 +47,7 @@ test.group('DynamoDB driver', (group) => {
4747
test,
4848
group,
4949
supportsMilliseconds: false,
50-
createStore: (options) =>
50+
createDriver: (options) =>
5151
new DynamoDB({
5252
prefix: 'japa',
5353
region: 'eu-west-3',

packages/bentocache/tests/drivers/file.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ test.group('File driver', (group) => {
99
registerCacheDriverTestSuite({
1010
test,
1111
group,
12-
createStore: (options) => {
12+
createDriver: (options) => {
1313
return new File({ prefix: 'japa', directory: fileURLToPath(BASE_URL), ...options })
1414
},
1515
})
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { KnexAdapter } from '../../../src/drivers/knex.js'
22
import type { KnexConfig } from '../../../src/types/main.js'
3-
import { DatabaseStore } from '../../../src/drivers/database.js'
3+
import { DatabaseDriver } from '../../../src/drivers/database.js'
44

55
export function createKnexStore(options: KnexConfig) {
66
const adapter = new KnexAdapter(options)
7-
return new DatabaseStore(adapter, options)
7+
return new DatabaseDriver(adapter, options)
88
}

packages/bentocache/tests/drivers/knex/mysql.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ test.group('Knex | MySQL driver', (group) => {
1414
test,
1515
group,
1616
supportsMilliseconds: false,
17-
createStore: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
17+
createDriver: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
1818
})
1919
})

packages/bentocache/tests/drivers/knex/postgres.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ test.group('Knex | MySQL driver', (group) => {
1414
test,
1515
group,
1616
supportsMilliseconds: false,
17-
createStore: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
17+
createDriver: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
1818
})
1919
})

packages/bentocache/tests/drivers/knex/sqlite.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ test.group('Knex | Better-sqlite3 driver', (group) => {
1414
registerCacheDriverTestSuite({
1515
test,
1616
group,
17-
createStore: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
17+
createDriver: (options) => createKnexStore({ connection: db, prefix: 'japa', ...options }),
1818
})
1919
})
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import type { KyselyConfig } from '../../../src/types/main.js'
22
import { KyselyAdapter } from '../../../src/drivers/kysely.js'
3-
import { DatabaseStore } from '../../../src/drivers/database.js'
3+
import { DatabaseDriver } from '../../../src/drivers/database.js'
44

55
export function createKyselyStore(options: KyselyConfig) {
66
const adapter = new KyselyAdapter(options)
7-
return new DatabaseStore(adapter, options)
7+
return new DatabaseDriver(adapter, options)
88
}

packages/bentocache/tests/drivers/kysely/mysql.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ test.group('Kysely | Mysql driver', (group) => {
1616
test,
1717
group,
1818
supportsMilliseconds: false,
19-
createStore: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
19+
createDriver: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
2020
})
2121
})

packages/bentocache/tests/drivers/kysely/postgres.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ test.group('Kysely | Postgres driver', (group) => {
1414
test,
1515
group,
1616
supportsMilliseconds: false,
17-
createStore: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
17+
createDriver: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
1818
})
1919
})

packages/bentocache/tests/drivers/kysely/sqlite.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ test.group('Kysely | Postgres driver', (group) => {
1616
test,
1717
group,
1818
supportsMilliseconds: false,
19-
createStore: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
19+
createDriver: (options) => createKyselyStore({ connection: db, prefix: 'japa', ...options }),
2020
})
2121
})

packages/bentocache/tests/drivers/memory.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ test.group('Memory Driver', (group) => {
77
registerCacheDriverTestSuite({
88
test,
99
group,
10-
createStore: (options) => new Memory({ maxItems: 1000, prefix: 'japa', ...options }),
10+
createDriver: (options) => new Memory({ maxItems: 1000, prefix: 'japa', ...options }),
1111
})
1212

1313
test('should not store items exceeding maxEntrySize', async ({ assert }) => {

packages/bentocache/tests/drivers/redis.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ test.group('Redis driver', (group) => {
99
registerCacheDriverTestSuite({
1010
test,
1111
group,
12-
createStore: (options) =>
12+
createDriver: (options) =>
1313
new Redis({ prefix: 'japa', connection: REDIS_CREDENTIALS, ...options }),
1414
})
1515

0 commit comments

Comments
 (0)