Skip to content

Commit b1ca768

Browse files
committed
Minor Composer & test refactoring
Override EOL
1 parent 29bffca commit b1ca768

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

src/Composer.php

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,13 @@
77
class Composer
88
{
99

10-
public ?string $EOL = null;
11-
12-
public function compose(EnvFile $file): string
10+
public function compose(EnvFile $file, ?string $overrideEOL = null): string
1311
{
1412
$visitor = new Visitor();
1513

1614
$file->visitBlocks($visitor);
1715

18-
$EOL = $this->EOL ?? $file->EOL;
16+
$EOL = $overrideEOL ?? $file->EOL;
1917
return implode($EOL, $visitor->results);
2018
}
2119

tests/Unit/ComposerTest.php

+13-11
Original file line numberDiff line numberDiff line change
@@ -11,34 +11,36 @@
1111
class ComposerTest extends TestCase
1212
{
1313

14+
private Composer $composer;
15+
16+
protected function setUp(): void
17+
{
18+
parent::setUp();
19+
20+
$this->composer = new Composer();
21+
}
22+
1423
public function testCompose(): void
1524
{
16-
$composer = new Composer();
1725
$file = new EnvFile();
1826

1927
$file->blocks[] = new CommentBlock("test1");
2028
$file->blocks[] = new CommentBlock("test2");
2129

22-
$result = $composer->compose($file);
30+
$result = $this->composer->compose($file);
2331
$this->assertEquals("#test1\n#test2", $result);
2432
}
2533

2634
public function testEOL(): void
2735
{
28-
$composer = new Composer();
2936
$file = new EnvFile();
3037

3138
$file->blocks[] = new CommentBlock("test1");
3239
$file->blocks[] = new CommentBlock("test2");
3340

34-
$file->EOL = EOLType::UNIX;
35-
$this->assertEquals("#test1\n#test2", $composer->compose($file));
36-
37-
$file->EOL = EOLType::WINDOWS;
38-
$this->assertEquals("#test1\r\n#test2", $composer->compose($file));
39-
40-
$composer->EOL = EOLType::UNIX;
41-
$this->assertEquals("#test1\n#test2", $composer->compose($file));
41+
$this->assertEquals("#test1\n#test2", $this->composer->compose($file, EOLType::UNIX));
42+
$this->assertEquals("#test1\r\n#test2", $this->composer->compose($file, EOLType::WINDOWS));
43+
$this->assertEquals("#test1\n#test2", $this->composer->compose($file, EOLType::UNIX));
4244
}
4345

4446
}

0 commit comments

Comments
 (0)