Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++Qt blocks allow for #[inherit] attribute on signals when it is unused and has no purpose there #1201

Open
ahayzen-kdab opened this issue Feb 28, 2025 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@ahayzen-kdab
Copy link
Collaborator

Currently you can write the following

unsafe extern "C++Qt" {
  type ExternObject;

  #[qsignal]
  #[inherit]
  fn method(self: &ExternObject);
}

Signals from C++Qt blocks do not have any difference from the inherit attribute, so likely we should disallow the attribute here?

Note the reason this currently works is that the parser code for signals is shared between RustQt and C++Qt blocks.

@ahayzen-kdab ahayzen-kdab added the 🪲 bug Something isn't working label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant