Skip to content

Commit 5919a43

Browse files
authored
Merge pull request #52 from KTH-Software-Engineering-DD2480/branch-coverage-validate-node-docs-#5
doc: document branch coverage improvement of `validateNode`
2 parents 13bd928 + 7f1915a commit 5919a43

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

Diff for: report.md

+16-2
Original file line numberDiff line numberDiff line change
@@ -412,15 +412,29 @@ The requirements + report can be found [here](https://docs.google.com/document/d
412412

413413
#### @nolanderc
414414

415-
`BinaryHeapArray.heapDown` before: 94.1%. `BinaryHeapArray.heapDown` after: 100.0%.
415+
`BinaryHeapArray.heapDown` before: 94.1%, after: 100.0%.
416416

417417
Branch coverage report: https://docs.google.com/document/d/1IVLQTIkl8IiemVskQ_JFw1sNe5EBXXEWpTxYIQ4-NV0/edit?usp=sharing
418418

419419
For new test cases, see:
420420

421+
```sh
422+
git show 395749c08a93e8b8a063e87849e44543fe1189ac
423+
```
424+
425+
Since the `heapDown` function already had such high branch coverage I also wrote
426+
tests for `BinaryHeapArray.validateNode`:
427+
428+
`BinaryHeapArray.validateNode` before: 57.7%, after: 100.0%.
429+
421430
```sh
422431
git show 8e6d8c7d8d36417133fe66f2c8d80a153d23b3f9
423-
git show 3596497b8e0af7a31921f6693173bdca5b2f2a36
432+
```
433+
434+
While writing these tests, I also found a bug in the source code. The fix can be seen here:
435+
436+
```sh
437+
git show 12d42662a86bc770915c15f5d2d24d877b107c06
424438
```
425439

426440
## Self-assessment: Way of working

0 commit comments

Comments
 (0)