No UnbndGenerator

[slegare2]

Any time I wanted to include an Unbinding interaction, I got the error

File "/home/slegare/ENS/venv_meta_update/lib/python3.6/site-packages/kami-1.2-py3.6.egg/kami/hierarchy.py", line 851, in add_interaction
    nugget, nugget_type = generate_from_interaction(self, interaction)
TypeError: 'NoneType' object is not iterable

I fixed this by adding the following at line 925 of generators.py

elif isinstance(interaction, Unbinding):
        gen = BndGenerator(hierarchy)
        return gen.generate(interaction)

It works since BndGenerator already sets the "test" parameter to False if the object is not an instance of Binding.
I am confused why this bug occured, since Unbindings were working properly in the past ?
If this fix is ok with you, I can push it.

[eugeniashurko]

Hi! I am in the middle of correcting it, sorry was busy a bit. Will push the fix soon. Don't really understand how it got broken, but Unbinding data structure is quite new in general and may be poorly tested

[slegare2]

ok thanks! I tested it. It seems to work well. Sebastien

…

On Wed, Sep 19, 2018 at 3:42 PM Eugenia Oshurko ***@***.***> wrote: Hi! I am in the middle of correcting it, sorry was busy a bit. Will push the fix soon. Don't really understand how it got broken, but Unbinding data structure is quite new in general and may be poorly tested — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWPyVK9x9u2PNZAwrS8cZf8BT_X31Lc4ks5uckmwgaJpZM4Wv9kT> .