Skip to content

Very low usage of submodule catch2 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asuessenbach opened this issue Mar 13, 2025 · 3 comments · Fixed by #1316
Closed

Very low usage of submodule catch2 #1303

asuessenbach opened this issue Mar 13, 2025 · 3 comments · Fixed by #1316
Assignees
@asuessenbach

Comments

@asuessenbach
Copy link
Contributor

Currently, the submodule catch2 is used for just very few (5?) unit tests.
We should either

  • add more unit tests to really have some benefit from having this test framework as part of our repository, or
  • remove those few tests and that submodule all together to slightly reduce the complexity of our repository.

Even though I really like test-driven development, it's not filled with life here. So I would prefer to remove catch2.
@SaschaWillems
Copy link
Collaborator

I'm with you. While having automated tests would be awesome, only having very few doesn't justify having a third party depdency.

@SaschaWillems SaschaWillems mentioned this issue Mar 22, 2025
Merged
13 tasks
@asuessenbach asuessenbach mentioned this issue Mar 25, 2025
Merged
20 tasks
@asuessenbach
Copy link
Contributor Author

I already had a PR to resolve this issue ready: #1316. So, no need for @gpx1000 to do anything (besides reviewing, of course:))

@asuessenbach asuessenbach assigned asuessenbach and unassigned gpx1000 Mar 25, 2025
@gpx1000
Copy link
Collaborator

gpx1000 commented Mar 25, 2025

:) One review incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asuessenbach asuessenbach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove little used submodule catch2. asuessenbach/Vulkan-Samples
3 participants
@gpx1000 @SaschaWillems @asuessenbach