Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI test for package exports #1285

Open
dstaley opened this issue Apr 27, 2020 · 0 comments
Open

Add CI test for package exports #1285

dstaley opened this issue Apr 27, 2020 · 0 comments
Assignees
@dstaley
Labels
enhancement stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.

Comments

@dstaley
Copy link
Member

dstaley commented Apr 27, 2020 •
edited
Loading

Based on the cool idea from then/is-promise#25, I think it'd be a great idea to add a new GitHub workflow check to confirm that our exports are properly importable in various environments.

I think we should probably check:

  • Rollup (to confirm ES modules import correctly)
  • Webpack (not totally sold on this one, but I'll think about it)

We can probably forgo Node at the moment since I don't really see the use-case until we support pluggable storage backends.
@dstaley dstaley self-assigned this Apr 27, 2020
@alexcottner alexcottner added the stale For marking issues as stale. Labeled issues will be closed soon if label is not removed. label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dstaley dstaley

Labels
enhancement stale For marking issues as stale. Labeled issues will be closed soon if label is not removed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstaley @alexcottner