-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Set encodings when reading config files #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kludex
merged 14 commits into
Kludex:main
from
secrett2633:fix_custom_encoding_support_config
Oct 26, 2025
+23
−3
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
116db50
handle multiple encodings when reading config files
secrett2633 86a7343
Apply ruff code formatting to config
secrett2633 435a262
Fix missing return statement in _read_file method
secrett2633 a49f8f4
Fix missing return statement in _read_file method
secrett2633 05ab680
Refactor test_config to handle multiple encodings for environment files
secrett2633 dc716a7
Refactor _read_file method to accept a custom encoding parameter and …
secrett2633 3b30b11
Merge branch 'master' into fix_multi_encoding_support_config
secrett2633 441b99e
Pass encoding parameter to _read_file method in Config class for impr…
secrett2633 5dea9fd
Add documentation for custom encoding support in environment files
secrett2633 2b231de
Merge branch 'main' into fix_custom_encoding_support_config
secrett2633 1aeb2d8
Update starlette/config.py
Kludex 10899f0
Merge branch 'main' into fix_custom_encoding_support_config
Kludex 897914d
Add test
Kludex af6ef5a
Merge branch 'main' into fix_custom_encoding_support_config
Kludex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.