Merge pull request #458 from Cognifide/bugfix/fix-http-repo-headers-config

Remove unused StringToPattern function

Author: tomaszmichalak

CHANGELOG.md

@@ -3,13 +3,14 @@ All notable changes to Knot.x will be documented in this file.
 
 ## Unreleased
 List of changes that are finished but not yet released in any final version.
- - [PR-427[(https://github.com/Cognifide/knotx/pull/427) - HttpRepositoryConnectorProxyImpl logging improvements
+ - [PR-427](https://github.com/Cognifide/knotx/pull/427) - HttpRepositoryConnectorProxyImpl logging improvements
  - [PR-422](https://github.com/Cognifide/knotx/pull/422) - Configurable Handlebars delimiters
  - [PR-428](https://github.com/Cognifide/knotx/pull/428) - Mark all Service Knot related classes deprecated.
  - [PR-432](https://github.com/Cognifide/knotx/pull/432) - Port unit and integration tests to JUnit 5
  - [PR-440](https://github.com/Cognifide/knotx/pull/440) - Enable different Vert.x Config stores types fix.
  - [PR-443](https://github.com/Cognifide/knotx/pull/443) - Update maven plugins versions.
  - [PR-445](https://github.com/Cognifide/knotx/pull/445) - Vert.x version upgrade to 3.5.3
+ - [PR-458](https://github.com/Cognifide/knotx/pull/458) - Remove unused StringToPattern function
 
 ## 1.3.0
  - [PR-376](https://github.com/Cognifide/knotx/pull/376) - Knot.x configurations refactor - Changed the way how configurations and it's defaults are build.

documentation/src/main/wiki/UpgradeNotes.md

@@ -5,14 +5,14 @@ from older than one version (e.g. 1.0.1 -> 1.1.2) be sure, to do all the steps f
 versions. You may see all changes in the [Changelog](https://github.com/Cognifide/knotx/blob/master/CHANGELOG.md).
 
 ## Master
-
- - [PR-427] https://github.com/Cognifide/knotx/pull/427 - HttpRepositoryConnectorProxyImpl logging improvements. Following log levels are now assigned depending on repository response status code:
+ - [PR-427](https://github.com/Cognifide/knotx/pull/427) - HttpRepositoryConnectorProxyImpl logging improvements. Following log levels are now assigned depending on repository response status code:
    ```2xx - success - log at debug
    3xx - redirect - log at info
    4xx - client error - log at warn
    5xx - server error - log at error
    other - log at warn
    ```
+ - [PR-458](https://github.com/Cognifide/knotx/pull/458) - HttpRepositoryOptions now supports plain regex, e.g. `*` is no longer specially treated, replace it to regex `.*`
 
 ## Version 1.3.0
 List of changes that are finished but not yet released in any final version.
@@ -36,35 +36,35 @@ List of changes that are finished but not yet released in any final version.
       - `customRequestHeader` property in the Service Adapter renamed to `customHttpHeader`
    - Knot.x instance auto-redeploy itself after the configuration is changed.
    - Get rid of configuration override through system properties - only specific verticles can implement it by themselves if required (currently server only)
- - [PR-399](https://github.com/Cognifide/knotx/pull/399) - `knotx-core` now contains all base Knot.x 
+ - [PR-399](https://github.com/Cognifide/knotx/pull/399) - `knotx-core` now contains all base Knot.x
  concepts, Server, Repositories, Splitter, Assembler and Gateway are now one `knotx-core` module. This
  is just the beginning of the bigger changes to make Knot.x more concise and easier to understand.
  - [PR-405](https://github.com/Cognifide/knotx/pull/405) and [PR-412](https://github.com/Cognifide/knotx/pull/412) - Update of dependencies management in the core project. Switched to BOM style dependencies: [`knotx-dependencies`](https://github.com/Knotx/knotx-dependencies).
  Your custom modules may now just elegantly depend on this module that defines all necessary Knot.x dependencies versions.
- - [PR-406](https://github.com/Cognifide/knotx/pull/406) and [PR-411](https://github.com/Cognifide/knotx/pull/411) - `example` and `standalone` modules were not conceptually a part of Knot.x `core`. 
+ - [PR-406](https://github.com/Cognifide/knotx/pull/406) and [PR-411](https://github.com/Cognifide/knotx/pull/411) - `example` and `standalone` modules were not conceptually a part of Knot.x `core`.
  They were introduces as a quickstart option but having it in the core repository was misleading. We removed those modules and enabled [`knotx-stack`](https://github.com/Knotx/knotx-stack) to enable even easier and faster setup of Knot.x instance.
  - [PR-419](https://github.com/Cognifide/knotx/pull/419) - Knotx snippets parameters prefix is now customizable, default value is
- still `data-knotx` (to keep compatibility), however expect that in the future it will be empty by default 
- (related to [PR-385](https://github.com/Cognifide/knotx/pull/385)). See more in [[Splitter|Splitter]] docs. 
- Important change - earlier `snippetTagName` was defined directly in Splitter and Assembler configs. 
+ still `data-knotx` (to keep compatibility), however expect that in the future it will be empty by default
+ (related to [PR-385](https://github.com/Cognifide/knotx/pull/385)). See more in [[Splitter|Splitter]] docs.
+ Important change - earlier `snippetTagName` was defined directly in Splitter and Assembler configs.
  Since this PR it will be defined in the `snippetOptions` section, under `tagName` property.
  - [PR-421](https://github.com/Cognifide/knotx/pull/421) - support for system properties injection in HOCON config files. You can now customize your config file to use values from system properties. See [System properties in Config](https://github.com/Cognifide/knotx/wiki/Configuration#system-properties) documentation.
 
 
 ## Version 1.2.1
-- [PR-385](https://github.com/Cognifide/knotx/pull/385) - From now on you can define the custom 
-`snippetTagName` and use that tag name to define dynamic snippets in the templates (instead of 
+- [PR-385](https://github.com/Cognifide/knotx/pull/385) - From now on you can define the custom
+`snippetTagName` and use that tag name to define dynamic snippets in the templates (instead of
 default `<script>`). Read more about that chang in [[Splitter|Splitter]] and [[Assembler|Assembler]] docs.
 
 ## Version 1.2.0
 - [PR-345](https://github.com/Cognifide/knotx/pull/335) - Update to Vert.x 3.5 and RxJava 2. Most notable changes are upgrade of Vert.x and RxJava.
 The API is changed, so your custom implementations need to adopt to the latest APIs both of Vert.x and RxJava.
 - [PR-320](https://github.com/Cognifide/knotx/pull/320) - Now you can configure the file-uploads folder for POST requests. See [Server options](https://github.com/Cognifide/knotx/wiki/Server#server-options) for details.
 - [PR-347](https://github.com/Cognifide/knotx/pull/320) - You can now add [custom response header](https://github.com/Cognifide/knotx/wiki/Server#server-options) to the Server. Also custom header can be added to [repository](https://github.com/Cognifide/knotx/wiki/HttpRepositoryConnector#options) & [service](https://github.com/Cognifide/knotx/wiki/HttpServiceAdapter#how-to-configure) requests.
-- [PR-349](https://github.com/Cognifide/knotx/pull/349) - You can pass [`Delivery Options`](http://vertx.io/docs/apidocs/io/vertx/core/eventbus/DeliveryOptions.html) to Knot.x Verticles e.g. to manipulate eventbus response timeouts. 
+- [PR-349](https://github.com/Cognifide/knotx/pull/349) - You can pass [`Delivery Options`](http://vertx.io/docs/apidocs/io/vertx/core/eventbus/DeliveryOptions.html) to Knot.x Verticles e.g. to manipulate eventbus response timeouts.
 For more details see documentation sections in [[Server|Server#vertx-event-bus-delivery-options]], [[Action Knot|ActionKnot#vertx-event-bus-delivery-options]] and [[Service Knot|ServiceKnot#vertx-event-bus-delivery-options]].
 - [PR-354](https://github.com/Cognifide/knotx/pull/354) - You can now enable XSRF protection on default or custom flow at any path. See [[Server|Server#how-to-enable-csrf-token-generation-and-validation]] for details.
-- [PR-359](https://github.com/Cognifide/knotx/pull/359) - From now on Knot.x responses with the response of a repository in case of response with status code different than 200. 
+- [PR-359](https://github.com/Cognifide/knotx/pull/359) - From now on Knot.x responses with the response of a repository in case of response with status code different than 200.
  You may play with [`displayExceptionDetails`](https://github.com/Cognifide/knotx/wiki/Server#server-options) flag
  in order to receive errors stack traces.
 - [PR-369](https://github.com/Cognifide/knotx/pull/369) - Better support for SSL for Repository Connector. Please check the documentation of [[HttpRepositoryConnector|HttpRepositoryConnector#how-to-configure-ssl-connection-to-the-repository]] for details of how to setup SSL connection.
@@ -74,9 +74,9 @@ For more details see documentation sections in [[Server|Server#vertx-event-bus-d
 
 ## Version 1.1.2
 - [PR-335](https://github.com/Cognifide/knotx/pull/335) - Added support for HttpServerOptions on the configuration level.
-  * **Important**: The biggest change here is the way port of [[Knot.x Server|Server#vertx-http-server-configurations]] is configured. 
-  Previously it was defined in the `config.httpPort` property. Now `serverOptions` section was introduced, see  
-  [Vert.x DataObjects page](http://vertx.io/docs/vertx-core/dataobjects.html#HttpServerOptions) for more details. 
+  * **Important**: The biggest change here is the way port of [[Knot.x Server|Server#vertx-http-server-configurations]] is configured.
+  Previously it was defined in the `config.httpPort` property. Now `serverOptions` section was introduced, see
+  [Vert.x DataObjects page](http://vertx.io/docs/vertx-core/dataobjects.html#HttpServerOptions) for more details.
   See example change of configuration
   [here](https://github.com/Cognifide/knotx/pull/335/files#diff-9eb56f60d7dcc72e56694b1a0aeb014dL5).
 
@@ -91,9 +91,9 @@ For more details see documentation sections in [[Server|Server#vertx-event-bus-d
   * **Important**: structure of [[Knot.x Server|Server]] configuration has changed because [[Gateway Mode|GatewayMode]] was introduced.
     Now, to configure custom `repositories`, `splitter`, `assembler` and `routing` move all those sections to `defaultFlow`.
     See the example change [here](https://github.com/Cognifide/knotx/pull/299/files#diff-d4c26ef67612264e462c7e4a882023cdL38).
-    Additionally, new configuration section (which is not mandatory) `customFlow` was introduced. Read more about it 
+    Additionally, new configuration section (which is not mandatory) `customFlow` was introduced. Read more about it
     in [[Gateway Mode|GatewayMode]] docs.
-- [PR-306](https://github.com/Cognifide/knotx/pull/306) - Additional parameters to adapter from template. 
+- [PR-306](https://github.com/Cognifide/knotx/pull/306) - Additional parameters to adapter from template.
   * You may pass additional parameters to Action Adapters using `data-knotx-adapter-params`. Read more in [[Action Knot|ActionKnot#example]] docs.
 
 ## Version 1.0.1