fix(market-metrics): exception when opening coin right after login

takenagain · takenagain · commit 0bb19e5519fc · 2025-03-05T11:47:26.000+02:00
diff --git a/lib/bloc/cex_market_data/profit_loss/profit_loss_bloc.dart b/lib/bloc/cex_market_data/profit_loss/profit_loss_bloc.dart
@@ -43,9 +43,10 @@ class ProfitLossBloc extends Bloc<ProfitLossEvent, ProfitLossState> {
     ProfitLossPortfolioChartLoadRequested event,
     Emitter<ProfitLossState> emit,
   ) async {
-    List<Coin> coins = await _removeUnsupportedCons(event);
-    // Charts for individual coins (coin details) are parsed here as well,
-    // and should be hidden if not supported.
+    try {
+      List<Coin> coins = await _removeUnsupportedCons(event);
+      // Charts for individual coins (coin details) are parsed here as well,
+      // and should be hidden if not supported.
       if (coins.isEmpty && event.coins.length <= 1) {
         return emit(
           PortfolioProfitLossChartUnsupported(
@@ -58,13 +59,14 @@ class ProfitLossBloc extends Bloc<ProfitLossEvent, ProfitLossState> {
           .then(emit.call)
           .catchError((e, _) {
         logger.log('Failed to load portfolio profit/loss: $e', isError: true);
-      if (state is! PortfolioProfitLossChartLoadSuccess) {
-        emit(
-          ProfitLossLoadFailure(
-            error: TextError(error: 'Failed to load portfolio profit/loss: $e'),
-            selectedPeriod: event.selectedPeriod,
-          ),
-        );
+        if (state is! PortfolioProfitLossChartLoadSuccess) {
+          emit(
+            ProfitLossLoadFailure(
+              error:
+                  TextError(error: 'Failed to load portfolio profit/loss: $e'),
+              selectedPeriod: event.selectedPeriod,
+            ),
+          );
         }
       });
 
@@ -76,9 +78,20 @@ class ProfitLossBloc extends Bloc<ProfitLossEvent, ProfitLossState> {
             .catchError((e, _) {
           // Ignore un-cached errors, as a transaction loading exception should not
           // make the graph disappear with a load failure emit, as the cached data
-        // is already displayed. The periodic updates will still try to fetch the
-        // data and update the graph.
-      });
+          // is already displayed. The periodic updates will still try to fetch the
+          // data and update the graph.
+        });
+      }
+    } catch (e) {
+      logger
+          .log('Failed to load portfolio profit/loss: $e', isError: true)
+          .ignore();
+      emit(
+        ProfitLossLoadFailure(
+          error: TextError(error: 'Failed to load portfolio profit/loss: $e'),
+          selectedPeriod: event.selectedPeriod,
+        ),
+      );
     }
 
     await emit.forEach(
diff --git a/lib/bloc/coins_bloc/coins_bloc.dart b/lib/bloc/coins_bloc/coins_bloc.dart
@@ -26,7 +26,7 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
     this._mm2Api,
   ) : super(CoinsState.initial()) {
     on<CoinsStarted>(_onCoinsStarted, transformer: droppable());
-    // TODO: move auth listener to ui layer: bloclistener fires auth events
+    // TODO: move auth listener to ui layer: bloclistener should fire auth events
     on<CoinsBalanceMonitoringStarted>(_onCoinsBalanceMonitoringStarted);
     on<CoinsBalanceMonitoringStopped>(_onCoinsBalanceMonitoringStopped);
     on<CoinsBalancesRefreshed>(_onCoinsRefreshed, transformer: droppable());
@@ -81,7 +81,7 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
       if (coin == null) return;
 
       // Get pubkeys from the SDK through the repo
-      final asset = _kdfSdk.assets.assetsFromTicker(event.coinId).single;
+      final asset = _kdfSdk.assets.available[coin.id]!;
       final pubkeys = await _kdfSdk.pubkeys.getPubkeys(asset);
 
       // Update state with new pubkeys
@@ -323,13 +323,22 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
     CoinsSessionStarted event,
     Emitter<CoinsState> emit,
   ) async {
-    _coinsRepo.flushCache();
-    _currentUserCache = event.signedInUser;
-    await _activateLoginWalletCoins(emit);
-    emit(state.copyWith(loginActivationFinished: true));
+    try {
+      _coinsRepo.flushCache();
+      _currentUserCache = event.signedInUser;
+      await _activateLoginWalletCoins(emit);
+      emit(state.copyWith(loginActivationFinished: true));
 
-    add(CoinsBalancesRefreshed());
-    add(CoinsBalanceMonitoringStarted());
+      add(CoinsBalancesRefreshed());
+      add(CoinsBalanceMonitoringStarted());
+    } catch (e, s) {
+      log(
+        'Error on login: $e',
+        isError: true,
+        trace: s,
+        path: 'coins_bloc => _onLogin',
+      ).ignore();
+    }
   }
 
   Future<void> _onLogout(
@@ -376,21 +385,20 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
     Iterable<String> coins,
     Emitter<CoinsState> emit,
   ) async {
-    // Start off by emitting the newly activated coins so that they all appear
-    // in the list at once, rather than one at a time as they are activated
-    _prePopulateListWithActivatingCoins(coins, emit);
-
     try {
+      // Start off by emitting the newly activated coins so that they all appear
+      // in the list at once, rather than one at a time as they are activated
+      emit(_prePopulateListWithActivatingCoins(coins));
+
       await _kdfSdk.addActivatedCoins(coins);
     } catch (e, s) {
       log(
-        'Failed to activate coins in SDK: $e',
+        'Failed to add activated coins to SDK metadata field: $e',
         isError: true,
         path: 'coins_bloc => _activateCoins',
         trace: s,
       ).ignore();
-      // Update state to reflect failure
-      return [];
+      rethrow;
     }
 
     final enabledAssets = await _kdfSdk.assets.getEnabledCoins();
@@ -414,10 +422,7 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
     return results;
   }
 
-  void _prePopulateListWithActivatingCoins(
-    Iterable<String> coins,
-    Emitter<CoinsState> emit,
-  ) {
+  CoinsState _prePopulateListWithActivatingCoins(Iterable<String> coins) {
     final activatingCoins = Map<String, Coin>.fromIterable(
       coins
           .map(
@@ -433,11 +438,9 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
           .cast<Coin>(),
       key: (element) => (element as Coin).abbr,
     );
-    emit(
-      state.copyWith(
-        walletCoins: {...state.walletCoins, ...activatingCoins},
-        coins: {...state.coins, ...activatingCoins},
-      ),
+    return state.copyWith(
+      walletCoins: {...state.walletCoins, ...activatingCoins},
+      coins: {...state.coins, ...activatingCoins},
     );
   }
 
@@ -466,10 +469,10 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
       }
     } catch (e, s) {
       log(
-        'Error activating coin ${coin!.id.toString()}',
+        'Error activating coin ${coin!.id}',
         isError: true,
         trace: s,
-      );
+      ).ignore();
     }
 
     return coin;
@@ -478,7 +481,7 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
   Future<Coin> _activateTrezorCoin(Coin coin, String coinId) async {
     final asset = _kdfSdk.assets.available[coin.id];
     if (asset == null) {
-      log('Failed to find asset for coin: ${coin.id}', isError: true);
+      log('Failed to find asset for coin: ${coin.id}', isError: true).ignore();
       return coin.copyWith(state: CoinState.suspended);
     }
     final accounts = await _trezorBloc.activateCoin(asset);
@@ -525,8 +528,9 @@ class CoinsBloc extends Bloc<CoinsEvent, CoinsState> {
           .map((coin) => coin.abbr)
           .toList();
 
-      coinsToBeActivated.addAll(suspended);
-      coinsToBeActivated.addAll(_getUnactivatedWalletCoins());
+      coinsToBeActivated
+        ..addAll(suspended)
+        ..addAll(_getUnactivatedWalletCoins());
 
       if (coinsToBeActivated.isEmpty) return;
       yield await _activateCoins(coinsToBeActivated, emit);
diff --git a/lib/bloc/coins_bloc/coins_repo.dart b/lib/bloc/coins_bloc/coins_repo.dart
@@ -7,6 +7,7 @@ import 'package:http/http.dart' as http;
 import 'package:komodo_defi_rpc_methods/komodo_defi_rpc_methods.dart'
     as kdf_rpc;
 import 'package:komodo_defi_sdk/komodo_defi_sdk.dart';
+import 'package:komodo_defi_types/komodo_defi_type_utils.dart';
 import 'package:komodo_defi_types/komodo_defi_types.dart';
 import 'package:komodo_ui_kit/komodo_ui_kit.dart';
 import 'package:web_dex/bloc/coins_bloc/asset_coin_extension.dart';
@@ -94,9 +95,7 @@ class CoinsRepo {
     return _assetToCoinWithoutAddress(asset);
   }
 
-  @Deprecated('Use KomodoDefiSdk assets or getCoinFromId instead. '
-      'This uses the deprecated assetsFromTicker method that uses a separate '
-      'cache that does not update with custom token activation.')
+  @Deprecated('Use KomodoDefiSdk assets or getCoinFromId instead.')
   Coin? getCoin(String coinId) {
     if (coinId.isEmpty) return null;
 
@@ -128,16 +127,23 @@ class CoinsRepo {
   }
 
   Future<Coin?> getEnabledCoin(String coinId) async {
-    final enabledAssets = _kdfSdk.assets.assetsFromTicker(coinId);
-    if (enabledAssets.length != 1) {
-      return null;
-    }
     final currentUser = await _kdfSdk.auth.currentUser;
     if (currentUser == null) {
       return null;
     }
 
-    final coin = _assetToCoinWithoutAddress(enabledAssets.single);
+    final enabledAssets = await _kdfSdk.assets.getEnabledCoins();
+    final enabledAsset = enabledAssets.firstWhereOrNull(
+      (asset) => asset == coinId,
+    );
+    if (enabledAsset == null) {
+      return null;
+    }
+
+    final coin = getCoin(enabledAsset);
+    if (coin == null) {
+      return null;
+    }
     final coinAddress = await getFirstPubkey(coin.abbr);
     return coin.copyWith(
       address: coinAddress,
@@ -229,7 +235,8 @@ class CoinsRepo {
     final isSignedIn = await _kdfSdk.auth.isSignedIn();
     if (!isSignedIn) {
       final coinIdList = assets.map((e) => e.id.id).join(', ');
-      log('No wallet signed in. Skipping activation of [$coinIdList}]');
+      log('No wallet signed in. Skipping activation of [$coinIdList}]')
+          .ignore();
       return;
     }
 
@@ -247,8 +254,9 @@ class CoinsRepo {
         await _broadcastAsset(coin.copyWith(state: CoinState.active));
       } catch (e, s) {
         log(
-          'Error activating coin: ${asset.id.id} \n$e',
+          'Error activating asset: ${asset.id.id} \n$e',
           isError: true,
+          path: 'coins_repo => activateAssetsSync',
           trace: s,
         ).ignore();
         await _broadcastAsset(
@@ -271,7 +279,8 @@ class CoinsRepo {
     final isSignedIn = await _kdfSdk.auth.isSignedIn();
     if (!isSignedIn) {
       final coinIdList = coins.map((e) => e.abbr).join(', ');
-      log('No wallet signed in. Skipping activation of [$coinIdList}]');
+      log('No wallet signed in. Skipping activation of [$coinIdList}]')
+          .ignore();
       return;
     }
 
@@ -478,7 +487,7 @@ class CoinsRepo {
       // Coins with the same coingeckoId supposedly have same usd price
       // (e.g. KMD == KMD-BEP20)
       final Iterable<Coin> samePriceCoins =
-          (getKnownCoins()).where((coin) => coin.coingeckoId == coingeckoId);
+          getKnownCoins().where((coin) => coin.coingeckoId == coingeckoId);
 
       for (final Coin coin in samePriceCoins) {
         prices[coin.abbr] = CexPrice(
