Skip to content

Commit ed01fe7

Browse files
committed
fixup! fixup! tiny fixes for kotlin 2.2 in gradle plugin
1 parent b80bde3 commit ed01fe7

File tree

4 files changed

+30
-8
lines changed

4 files changed

+30
-8
lines changed

build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ allprojects {
208208
configure<BuildConfigExtension> {
209209
packageName = "org.jetbrains.kotlinx.dataframe"
210210
className = "BuildConfig"
211+
buildConfigField("KOTLIN_VERSION", libs.versions.kotlin.asProvider().get())
211212
buildConfigField("VERSION", "${project.version}")
212213
buildConfigField("DEBUG", findProperty("kotlin.dataframe.debug")?.toString()?.toBoolean() ?: false)
213214
}

plugins/dataframe-gradle-plugin/build.gradle.kts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
plugins {
22
`kotlin-dsl`
3-
`java-gradle-plugin`
43
`maven-publish`
4+
alias(libs.plugins.buildconfig)
55
alias(libs.plugins.plugin.publish)
66
alias(libs.plugins.ktlint)
77
}
@@ -14,26 +14,34 @@ repositories {
1414

1515
group = "org.jetbrains.kotlinx.dataframe"
1616

17+
buildscript {
18+
dependencies {
19+
classpath(embeddedKotlin("gradle-plugin"))
20+
}
21+
}
22+
1723
dependencies {
1824
api(libs.kotlin.reflect)
1925
implementation(projects.dataframe)
2026
// experimental
2127
implementation(projects.dataframeOpenapiGenerator)
2228

29+
compileOnly(embeddedKotlin("gradle-plugin"))
2330
implementation(libs.kotlin.gradle.plugin.api)
24-
compileOnly(libs.kotlin.gradle.plugin)
2531
implementation(libs.serialization.core)
2632
implementation(libs.serialization.json)
2733
implementation(libs.ksp.gradle)
2834
implementation(libs.ksp.api)
2935

30-
testImplementation(libs.junit)
36+
testImplementation(gradleTestKit())
37+
testImplementation(embeddedKotlin("test"))
38+
testImplementation(embeddedKotlin("test-junit"))
3139
testImplementation(libs.kotestAssertions)
3240
testImplementation(libs.android.gradle.api)
3341
testImplementation(libs.android.gradle)
42+
testImplementation(embeddedKotlin("gradle-plugin"))
3443
testImplementation(libs.ktor.server.netty)
3544
testImplementation(libs.h2db)
36-
testImplementation(gradleApi())
3745
}
3846

3947
tasks.withType<ProcessResources> {
@@ -100,6 +108,10 @@ val integrationTestConfiguration by configurations.creating {
100108
extendsFrom(configurations.testImplementation.get())
101109
}
102110

111+
tasks.pluginUnderTestMetadata {
112+
pluginClasspath.from(integrationTestConfiguration)
113+
}
114+
103115
val integrationTestTask = tasks.register<Test>("integrationTest") {
104116
dependsOn(":plugins:symbol-processor:publishToMavenLocal")
105117
dependsOn(":dataframe-arrow:publishToMavenLocal")

plugins/dataframe-gradle-plugin/src/main/kotlin/org/jetbrains/dataframe/gradle/SchemaGeneratorPlugin.kt

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.jetbrains.dataframe.gradle
22

3+
import com.google.devtools.ksp.gradle.KspAATask
4+
import com.google.devtools.ksp.gradle.KspTask
35
import com.google.devtools.ksp.gradle.KspTaskJvm
46
import org.gradle.api.Plugin
57
import org.gradle.api.Project
@@ -13,7 +15,7 @@ import org.jetbrains.kotlin.gradle.dsl.KotlinAndroidProjectExtension
1315
import org.jetbrains.kotlin.gradle.dsl.KotlinJvmProjectExtension
1416
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
1517
import org.jetbrains.kotlin.gradle.dsl.KotlinProjectExtension
16-
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
18+
import org.jetbrains.kotlin.gradle.tasks.BaseKotlinCompile
1719
import java.io.File
1820
import java.net.URL
1921
import java.nio.file.Path
@@ -42,10 +44,15 @@ class SchemaGeneratorPlugin : Plugin<Project> {
4244
group = GROUP
4345
dependsOn(*generationTasks.toTypedArray())
4446
}
45-
tasks.withType(KspTaskJvm::class.java).configureEach {
47+
tasks.withType(KspTask::class.java).configureEach {
4648
dependsOn(generateAll)
49+
dependsOn(*generationTasks.toTypedArray())
50+
}
51+
tasks.withType(KspAATask::class.java).configureEach {
52+
dependsOn(generateAll)
53+
dependsOn(*generationTasks.toTypedArray())
4754
}
48-
tasks.withType<KotlinCompile> {
55+
tasks.withType(BaseKotlinCompile::class.java).configureEach {
4956
dependsOn(generateAll)
5057
}
5158
}

plugins/dataframe-gradle-plugin/src/test/kotlin/org/jetbrains/dataframe/gradle/TestData.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.jetbrains.dataframe.gradle
22

3+
import org.jetbrains.kotlinx.dataframe.BuildConfig
4+
35
object TestData {
46

57
val csvSample =
@@ -15,5 +17,5 @@ object TestData {
1517

1618
val jsonName = "test.json"
1719

18-
val kotlinVersion = "1.6.0"
20+
val kotlinVersion = BuildConfig.KOTLIN_VERSION
1921
}

0 commit comments

Comments
 (0)