Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangerous Default impl for Point #161

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix dangerous Default impl for Point #161

merged 1 commit into from
May 3, 2023

Conversation

LLFourn
Copy link
Owner

@LLFourn LLFourn commented May 3, 2023

You could get a zero point in a NonZero Point

fixes #150

@LLFourn
Fix NonZero violation with Point::default
5fcc773 
Default for NonZero Point was zero 🤦
@LLFourn LLFourn force-pushed the dangerous-default branch from 1184dbb to 5fcc773 Compare May 3, 2023 07:22
@LLFourn LLFourn merged commit de2f2f3 into master May 3, 2023
@LLFourn LLFourn deleted the dangerous-default branch May 3, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfarrow nickfarrow nickfarrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Point default is Zero while marked as NonZero
2 participants
@LLFourn @nickfarrow