Prevent apt-get from installing cmake, remove cmake from list of external packages for spack to find, remove not-buildable option from spack external find (might bring it back)

Author: ldowen

Dockerfile

@@ -31,7 +31,7 @@ ARG HOST_CONFIG=docker-$SPEC
 ENV DEBIAN_FRONTEND=noninteractive
 RUN apt-get update -y
 RUN apt-get upgrade -y
-RUN apt-get install -y build-essential git gfortran mpich autotools-dev autoconf sqlite pkg-config uuid gettext cmake libncurses-dev libgdbm-dev libffi-dev libssl-dev libexpat-dev libreadline-dev libbz2-dev locales python python3 unzip libtool wget curl tk-dev
+RUN apt-get install -y build-essential git gfortran mpich autotools-dev autoconf sqlite pkg-config uuid gettext libncurses-dev libgdbm-dev libffi-dev libssl-dev libexpat-dev libreadline-dev libbz2-dev locales python python3 unzip libtool wget curl tk-dev
 RUN apt-get install -y python3-dev python3-venv python3-pip
 RUN apt-get install -y iputils-ping
 

scripts/devtools/tpl-manager.py

@@ -149,18 +149,17 @@ def custom_spack_env(self, env_dir, env_name):
 
         # Find external packages and compilers
         # List of packages to find externally
-        ext_packages = ["cmake", "git", "python"]
+        ext_packages = ["git", "pkg-config", "autoconf", "automake"]
         if (not spack.spec.Spec(self.args.spec).satisfies("~mpi")):
             ext_packages.append("mpich")
         comp_cmd("find") # spack compiler find
-        ext_cmd("find", "--not-buildable") # spack external find --not-buildable
         # Ignore any packages that are already found
         cur_packages = spack.config.get("packages")
         for i in ext_packages:
             if (i in cur_packages):
                 ext_packages.remove(i)
-        for i in ext_packages:
-            ext_cmd("find", "--not-buildable", i)
+        ext_cmd("find", *ext_packages)
+        cur_packages = spack.config.get("packages")
         # TODO: Add logic to inform user when packages arent found
         # to encourage them to potentially add their own paths
         # Always add the spec for a custom environment