Fix mixer EffectRackView GUI glitch
#7511
Conversation
Rossmaxx
force-pushed
the
fix-mixer-bug
branch
from
7308ba3
to
aa2a20f
Compare
|
It seems fixed on my end. It would help if anyone else confirms the fix. |
This seem to fix the mixer effect chain gui but not the instrument effect chain. |
|
Zonk can you clarify with screenshots? |
|
This is the problem @zonkmachine is referring to @Rossmaxx. |
|
I don't think it was right to merge the instrument & effect chain resize changes in #7453. I feel like that PR should have been more focused on making SlicerT use the resize changes after they were implemented in another PR rather than it implementing them and then using it. It would have make reviewing a bit easier I think, and we would've had a better chance at catching these problems. |
|
Thanks saker, I'll look into that too. |
|
I tried to fix the instrument effect view getting chopped but couldn't figure out what file to actually edit. I tried a couple different files but none of those fixed it. I'll be afk for a few days so if someone finds a fix, feel free to push to this branch and merge this. |
| @@ -289,7 +289,7 @@ InstrumentTrackWindow::InstrumentTrackWindow( InstrumentTrackView * _itv ) : | |||
| flags |= Qt::MSWindowsFixedSizeDialogHint; | |||
| // any better way than this? | |||
| } else { | |||
| subWin->setMaximumSize(m_instrumentView->maximumHeight() + 12, m_instrumentView->maximumWidth() + 208); | |||
| subWin->setMaximumSize(m_instrumentView->maximumWidth() + 12, m_instrumentView->maximumHeight() + 208); | |||
There was a problem hiding this comment.
Would it be better to use setFixedSize here rather than calling both setMinimumSize and setMaximumSize?
There was a problem hiding this comment.
I believe this has got something to do with resize ability
|
Closing in favour of #7519 |
fixes: #7508, #7510