Skip to content

Commit 66de977

Browse files
EliahKaganLuaKT
authored andcommitted
Add more push and workflow_dispatch triggers
- Trigger `msrv.yml` on the push event, for the same branches for which `ci.yml` is triggered on it. That is, make the corresponding change to the MSRV workflow that was made to the test workflow. - Remove outdated comments on `msrv.yml`. These comments already disagreed with the code, since they named `master` when the branch was `main`, and suggested that all pull requests would trigger the workflow when really was (and continues to be) also limited by branch. - Add `workflow_dispatch` to the `ci.yml` and `msrv.tml` workflows, so they can be manually run even for branches that are not named, and in the case of `ci.yml`, so it can be manually run even when changes are not made to any of the paths that are also needed to trigger it on the push or pull_request events. - Put `workflow_dispatch` last in the `release.yml` workflow that already had it. Currently it is a secondary way to trigger all workflows that include it. It was in practice the primary way to trigger `release.yml` when the push trigger was broken, but that is no longer the case since 286e388 (GitoxideLabs#1475). Even in testing, it is now most often run by pushing a tag. This brings its style in line with the style in `cron.yml`, where `workflow_dispatch` was already a secondary way to trigger the workflow and listed second.
1 parent a2e1878 commit 66de977

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ on:
3535
- 'gix*/**'
3636
- '*.toml'
3737
- Makefile
38+
workflow_dispatch:
3839

3940
jobs:
4041
pure-rust-build:

.github/workflows/msrv.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
name: Minimum Supported Rust Version
22

33
on:
4-
# Trigger the workflow on push to master or any pull request
5-
# Ignore all tags
64
push:
7-
branches: [ main ]
8-
tags-ignore: [ '*' ]
5+
branches:
6+
- main
7+
- 'run-ci/**'
8+
- '**/run-ci/**'
9+
tags-ignore:
10+
- '*'
911
pull_request:
10-
branches: [ main ]
12+
branches:
13+
- main
14+
workflow_dispatch:
1115

1216
jobs:
1317
rustfmt:

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
name: release
55

66
on:
7-
workflow_dispatch:
87
push:
98
# Enable when testing release infrastructure on a branch.
109
# branches:
1110
# - fix-releases
1211
tags:
1312
- 'v*'
13+
workflow_dispatch:
1414

1515
defaults:
1616
run:

0 commit comments

Comments
 (0)