Skip to content

Commit 63ea0ff

Browse files
committed
Code review suggestions
1 parent 4716b43 commit 63ea0ff

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

template/.github/workflows/ci.yaml.jinja

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ jobs:
2626
contents: read
2727
pull-requests: read # needed to check if PR exists for current branch
2828
outputs:
29-
should-run: ${{ steps.check.outputs.should-run}}
29+
should-run: ${{ steps.check.outputs.should-run }}
3030
steps:
3131
- name: Checkout code
32-
uses: actions/checkout@v6.0.1
32+
uses: actions/checkout@{% endraw %}{{ gha_checkout }}{% raw %}
3333
with:
3434
persist-credentials: false
3535
- id: check
@@ -215,10 +215,10 @@ jobs:
215215
if [[ "${{ needs.check-skip-duplicate.result }}" =~ $failure_pattern ]] ||
216216
[[ "${{ needs.iac-management-pulumi.result }}" =~ $failure_pattern ]] ||
217217
[[ "${{ needs.artifact-stores-pulumi.result }}" =~ $failure_pattern ]] ||
218-
[[ "${{ needs.central-networking-pulumi.result }}" =~ $failure_pattern ]] ||
219-
[[ "${{ needs.identity-center-pulumi.result }}" =~ $failure_pattern ]] ||
220-
[[ "${{ needs.github-repos-pulumi.result }}" =~ $failure_pattern ]] ||
221-
[[ "${{ needs.okta-pulumi.result }}" =~ $failure_pattern ]]; then
218+
[[ "${{ needs.central-networking-pulumi.result }}" =~ $failure_pattern ]]{% endraw %}{% if initial_iac_management_deploy_occurred %}{% raw %} ||
219+
[[ "${{ needs.identity-center-pulumi.result }}" =~ $failure_pattern ]]{% endraw %}{% endif %}{% if manage_github_repos %}{% raw %} ||
220+
[[ "${{ needs.github-repos-pulumi.result }}" =~ $failure_pattern ]]{% endraw %}{% endif %}{% if manage_okta %}{% raw %} ||
221+
[[ "${{ needs.okta-pulumi.result }}" =~ $failure_pattern ]]{% endraw %}{% endif %}{% raw %}; then
222222
echo "❌ One or more jobs failed or were cancelled"
223223
exit 1
224224
fi

0 commit comments

Comments
 (0)