Skip to content

Commit 8eaa4f2

Browse files
authored
update hub start script (#4)
* update hub start script * update CI vars
1 parent fddcbe5 commit 8eaa4f2

File tree

6 files changed

+15
-5
lines changed

6 files changed

+15
-5
lines changed

.github/workflows/build-docker.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ on:
1515
workflow_dispatch:
1616

1717
env:
18-
REGISTRY_URL: "docker.io" # docker.io or other registry URL, DOCKER_REGISTRY_USER/DOCKER_REGISTRY_PASSWORD to be set in CI env.
18+
REGISTRY_URL: "docker.io" # docker.io or other registry URL, DOCKER_REGISTRY_USERNAME/DOCKER_REGISTRY_PASSWORD to be set in CI env.
1919
BUILDKIT_PROGRESS: "plain" # Full logs for CI build.
2020

21-
# DOCKER_REGISTRY_USER and DOCKER_REGISTRY_PASSWORD is required for docker image push, they should be set in CI secrets.
22-
DOCKER_REGISTRY_USER: ${{ secrets.DOCKER_REGISTRY_USER }}
21+
# DOCKER_REGISTRY_USERNAME and DOCKER_REGISTRY_PASSWORD is required for docker image push, they should be set in CI secrets.
22+
DOCKER_REGISTRY_USERNAME: ${{ secrets.DOCKER_REGISTRY_USERNAME }}
2323
DOCKER_REGISTRY_PASSWORD: ${{ secrets.DOCKER_REGISTRY_PASSWORD }}
2424

2525
# used to sync image to mirror registry

docker_dev_box/hub.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ COPY work /opt/utils/
1515

1616
# Setup JupyterHub
1717
RUN source /opt/utils/script-devbox-jupyter.sh \
18+
&& mv /opt/utils/start-*.sh /usr/local/bin/ && chmod +x /usr/local/bin/start-*.sh \
1819
&& for profile in $(echo $ARG_PROFILE_JUPYTER | tr "," "\n") ; do ( setup_jupyter_${profile} || true ) ; done \
1920
# If not keeping NodeJS, remove NoedJS to reduce image size, and install Traefik instead
2021
&& ${ARG_KEEP_NODEJS:-true} || ( \
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
#!/bin/bash
2+
[ $BASH ] && [ -f /etc/profile ] && [ -z $ENTER_PROFILE ] && . /etc/profile
3+
24
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
35

4-
jupyterhub $*
6+
# echo "DIR=${DIR}"
7+
# ls -alh
8+
9+
python -m jupyterhub $*

docker_dev_box/work/start-notebook.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#!/bin/bash
2+
[ $BASH ] && [ -f /etc/profile ] && [ -z $ENTER_PROFILE ] && . /etc/profile
3+
24
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
35
. $DIR/start--pre.sh
46

docker_dev_box/work/start-singleuser.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#!/bin/bash
2+
[ $BASH ] && [ -f /etc/profile ] && [ -z $ENTER_PROFILE ] && . /etc/profile
3+
24
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
35
. $DIR/start--pre.sh
46

tool.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ push_image() {
5858
KEYWORD="${1:-second}";
5959
docker image prune --force && docker images | sort;
6060
IMAGES=$(docker images | grep "${KEYWORD}" | awk '{print $1 ":" $2}') ;
61-
echo "$DOCKER_REGISTRY_PASSWORD" | docker login "${REGISTRY_URL}" -u "$DOCKER_REGISTRY_USER" --password-stdin ;
61+
echo "$DOCKER_REGISTRY_PASSWORD" | docker login "${REGISTRY_URL}" -u "$DOCKER_REGISTRY_USERNAME" --password-stdin ;
6262
for IMG in $(echo "${IMAGES}" | tr " " "\n") ;
6363
do
6464
docker push "${IMG}";

0 commit comments

Comments
 (0)