Skip to content

Commit b32fa40

Browse files
committed
fixed failing tests that were supposed to fail anyway
1 parent 83f9ddc commit b32fa40

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

pyoracle_forms/generic_object.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ def query_type(self) -> int:
9595
return query_type(self)
9696

9797
def duplicate(self, new_owner: GenericObject, new_name: str) -> NoReturn:
98-
raise NotImplementedError() # pragma: no cover
98+
raise NotImplementedError()
9999

100100
def replicate(self, new_owner: GenericObject, new_name: str) -> NoReturn:
101-
raise NotImplementedError() # pragma: no cover
101+
raise NotImplementedError()
102102

103103
def find_object(self, name: str, object_type: FormsObjects) -> NoReturn:
104-
raise NotImplementedError() # pragma: no cover
104+
raise NotImplementedError()
105105

106106
def inherit_property(self, property_type: Properties) -> NoReturn:
107107
raise NotImplementedError()
@@ -113,7 +113,7 @@ def is_property_default(self, property_type: Properties) -> NoReturn:
113113
raise NotImplementedError()
114114

115115
def is_subclassed(self) -> NoReturn:
116-
raise NotImplementedError() # pragma: no cover
116+
raise NotImplementedError()
117117

118118
def __repr__(self) -> str:
119119
return f"{self.__class__.__name__}({repr(self._as_parameter_)})"

tests/test_item.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import pytest
22

3-
from pyoracle_forms import Properties
3+
from pyoracle_forms import Properties, FormsObjects
44
from pyoracle_forms import Item, FormsException
55

66

@@ -66,7 +66,7 @@ def test_duplicate(new_item):
6666

6767
@pytest.mark.xfail
6868
def test_replicate(new_item):
69-
replicated = new_item.duplicate(new_item.owning_object, "REPLICATED_ITM")
69+
replicated = new_item.replicate(new_item.owning_object, "REPLICATED_ITM")
7070

7171
assert replicated.name == "REPLICATED_ITEM"
7272

@@ -75,7 +75,9 @@ def test_replicate(new_item):
7575
def test_find_object(new_item):
7676
to_find = new_item.name
7777

78-
assert new_item.owning_object.find_object(to_find).name == to_find
78+
assert (
79+
new_item.owning_object.find_object(to_find, FormsObjects.item).name == to_find
80+
)
7981

8082

8183
@pytest.mark.xfail

0 commit comments

Comments
 (0)