Fixed the observations and timeseries get function throwing an error for an undefined id

LaurentGoderre · LaurentGoderre · commit f62684554e17 · 2019-10-30T20:15:14.000Z
diff --git a/api/endpoints/observations/model.js b/api/endpoints/observations/model.js
@@ -139,7 +139,7 @@ module.exports = {
 			await client.connect().catch(reject);
 			const res = await client.query(getQuery, [id]).catch(reject);
 			client.end();
-			resolve(format(res.rows[0], urlResolver));
+			resolve(res.rowCount > 0 ? format(res.rows[0], urlResolver) : undefined);
 		});
 	}
 };
diff --git a/api/endpoints/timeseries/model.js b/api/endpoints/timeseries/model.js
@@ -86,7 +86,7 @@ module.exports = {
 			await client.connect().catch(reject);
 			const res = await client.query(getQuery, [id]).catch(reject);
 			client.end();
-			resolve(format(res.rows[0], urlResolver));
+			resolve(res.rowCount > 0 ? format(res.rows[0], urlResolver) : undefined);
 		});
 	},
 	listObservations: async function(id, start, count, urlResolver = defaultUrlResolver, options) {

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ module.exports = {`
`139`	`139`	`await client.connect().catch(reject);`
`140`	`140`	`const res = await client.query(getQuery, [id]).catch(reject);`
`141`	`141`	`client.end();`
`142`		`- resolve(format(res.rows[0], urlResolver));`
	`142`	`+ resolve(res.rowCount > 0 ? format(res.rows[0], urlResolver) : undefined);`
`143`	`143`	`});`
`144`	`144`	`}`
`145`	`145`	`};`