refactor: make AVSRegistrar abstract

Author: 0xClandestine

src/middlewareV2/registrar/AVSRegistrar.sol

@@ -16,7 +16,7 @@ import {AVSRegistrarStorage} from "./AVSRegistrarStorage.sol";
 import {Initializable} from "@openzeppelin-upgrades/contracts/proxy/utils/Initializable.sol";
 
 /// @notice A minimal AVSRegistrar contract that is used to register/deregister operators for an AVS
-contract AVSRegistrar is Initializable, AVSRegistrarStorage {
+abstract contract AVSRegistrar is Initializable, AVSRegistrarStorage {
     using OperatorSetLib for OperatorSet;
 
     modifier onlyAllocationManager() {

test/unit/middlewareV2/AVSRegistrarBase.t.sol

@@ -16,6 +16,21 @@ import {
 import {ArrayLib} from "eigenlayer-contracts/src/test/utils/ArrayLib.sol";
 import "test/utils/Random.sol";
 
+contract AVSRegistrarImplementation is AVSRegistrar {
+    constructor(
+        IAllocationManager _allocationManager,
+        IKeyRegistrar _keyRegistrar
+    ) AVSRegistrar(_allocationManager, _keyRegistrar) {
+        _disableInitializers();
+    }
+
+    function initialize(
+        address _owner
+    ) external initializer {
+        __AVSRegistrar_init(_owner);
+    }
+}
+
 abstract contract AVSRegistrarBase is
     MockEigenLayerDeployer,
     IAVSRegistrarErrors,

test/unit/middlewareV2/AVSRegistrarUnit.t.sol

@@ -8,15 +8,19 @@ contract AVSRegistrarUnitTests is AVSRegistrarBase {
     function setUp() public override {
         super.setUp();
 
-        avsRegistrarImplementation = new AVSRegistrar(
-            IAllocationManager(address(allocationManagerMock)),
-            IKeyRegistrar(address(keyRegistrarMock))
+        avsRegistrarImplementation = AVSRegistrar(
+            new AVSRegistrarImplementation(
+                IAllocationManager(address(allocationManagerMock)),
+                IKeyRegistrar(address(keyRegistrarMock))
+            )
         );
 
         avsRegistrar = AVSRegistrar(
             address(
                 new TransparentUpgradeableProxy(
-                    address(avsRegistrarImplementation), address(proxyAdmin), ""
+                    address(avsRegistrarImplementation),
+                    address(proxyAdmin),
+                    abi.encodeWithSelector(AVSRegistrarImplementation.initialize.selector, AVS)
                 )
             )
         );