test: assert on state and event

Author: stevennevins

src/StakeRegistry.sol

@@ -799,9 +799,8 @@ contract StakeRegistry is StakeRegistryStorage {
      * @param _stakeType The type of stake to track (TOTAL_DELEGATED, TOTAL_SLASHABLE, or BOTH)
      */
     function _setStakeType(uint8 quorumNumber, StakeType _stakeType) internal {
-        StakeType oldStakeType = stakeTypePerQuorum[quorumNumber];
         stakeTypePerQuorum[quorumNumber] = _stakeType;
-        emit StakeTypeSet(oldStakeType, _stakeType);
+        emit StakeTypeSet(_stakeType);
     }
 
     /**

src/interfaces/IStakeRegistry.sol

@@ -55,7 +55,7 @@ interface IStakeRegistry is IRegistry {
     event LookAheadPeriodChanged(uint32 oldLookAheadDays, uint32 newLookAheadDays);
 
     /// @notice emitted when the stake type is updated
-    event StakeTypeSet(StakeType previousStakeType, StakeType newStakeType);
+    event StakeTypeSet(StakeType newStakeType);
     /// @notice emitted when the minimum stake for a quorum is updated
     event MinimumStakeForQuorumUpdated(uint8 indexed quorumNumber, uint96 minimumStake);
     /// @notice emitted when a new quorum is created

test/unit/StakeRegistryUnit.t.sol

@@ -102,6 +102,9 @@ contract StakeRegistryUnitTests is MockAVSDeployer, IStakeRegistryEvents {
         cheats.prank(address(registryCoordinator));
         stakeRegistry.initializeDelegatedStakeQuorum(quorumNumber, minimumStake, strategyParams);
 
+        StakeType stakeType = stakeRegistry.stakeTypePerQuorum(quorumNumber);
+        assertEq(uint8(stakeType), uint8(StakeType.TOTAL_DELEGATED), "invalid stake type");
+
         // Mark quorum initialized for other tests
         initializedQuorumBitmap = uint192(initializedQuorumBitmap.setBit(quorumNumber));
         initializedQuorumBytes = initializedQuorumBitmap.bitmapToBytesArray();
@@ -614,6 +617,7 @@ contract StakeRegistryUnitTests_Config is StakeRegistryUnitTests {
         cheats.prank(address(registryCoordinator));
         stakeRegistry.initializeDelegatedStakeQuorum(quorumNumber, minimumStake, strategyParams);
     }
+    event StakeTypeSet(StakeType newStakeType);
 
     function test_initializeSlashableStakeQuorum() public {
         uint8 quorumNumber = nextQuorum;
@@ -626,6 +630,8 @@ contract StakeRegistryUnitTests_Config is StakeRegistryUnitTests {
         );
 
         cheats.prank(address(registryCoordinator));
+        cheats.expectEmit(true, true, true, true);
+        emit StakeTypeSet(StakeType.TOTAL_SLASHABLE);
         stakeRegistry.initializeSlashableStakeQuorum(
             quorumNumber,
             minimumStake,