Skip to content

Commit aefc284

Browse files
committed
fix: tests
1 parent d33fd9d commit aefc284

File tree

1 file changed

+15
-51
lines changed

1 file changed

+15
-51
lines changed

test/unit/middlewareV2/AVSRegistrarAsIdentifierUnit.t.sol

Lines changed: 15 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ contract AVSRegistrarAsIdentifierUnitTests is AVSRegistrarBase {
3636
address(avsRegistrarImplementation),
3737
address(proxyAdmin),
3838
abi.encodeWithSelector(
39-
AVSRegistrarAsIdentifier.initialize.selector, address(this), METADATA_URI
39+
AVSRegistrarAsIdentifier.initialize.selector, AVS, METADATA_URI
4040
)
4141
)
4242
)
@@ -74,6 +74,14 @@ contract AVSRegistrarAsIdentifierUnitTests_constructor is AVSRegistrarAsIdentifi
7474

7575
contract AVSRegistrarAsIdentifierUnitTests_initialize is AVSRegistrarAsIdentifierUnitTests {
7676
function test_initialize() public {
77+
avsRegistrarAsIdentifier = AVSRegistrarAsIdentifier(
78+
address(
79+
new TransparentUpgradeableProxy(
80+
address(avsRegistrarImplementation), address(proxyAdmin), ""
81+
)
82+
)
83+
);
84+
7785
// Mock the allocationManager calls
7886
vm.mockCall(
7987
address(allocationManagerMock),
@@ -131,8 +139,8 @@ contract AVSRegistrarAsIdentifierUnitTests_initialize is AVSRegistrarAsIdentifie
131139
)
132140
);
133141

134-
// // Initialize
135-
// avsRegistrarAsIdentifier.initialize(admin, METADATA_URI);
142+
// Initialize
143+
avsRegistrarAsIdentifier.initialize(admin, METADATA_URI);
136144
}
137145

138146
function test_revert_alreadyInitialized() public {
@@ -210,29 +218,6 @@ contract AVSRegistrarAsIdentifierUnitTests_supportsAVS is AVSRegistrarAsIdentifi
210218
contract AVSRegistrarAsIdentifierUnitTests_registerOperator is AVSRegistrarAsIdentifierUnitTests {
211219
using ArrayLib for *;
212220

213-
function setUp() public virtual override {
214-
super.setUp();
215-
216-
// Initialize the contract
217-
vm.mockCall(
218-
address(allocationManagerMock),
219-
abi.encodeWithSelector(IAllocationManager.updateAVSMetadataURI.selector),
220-
""
221-
);
222-
vm.mockCall(
223-
address(allocationManagerMock),
224-
abi.encodeWithSelector(IAllocationManager.setAVSRegistrar.selector),
225-
""
226-
);
227-
vm.mockCall(
228-
address(permissionController),
229-
abi.encodeWithSelector(IPermissionController.addPendingAdmin.selector),
230-
""
231-
);
232-
233-
// avsRegistrarAsIdentifier.initialize(admin, METADATA_URI);
234-
}
235-
236221
function testFuzz_revert_notAllocationManager(
237222
address notAllocationManager
238223
) public filterFuzzedAddressInputs(notAllocationManager) {
@@ -270,14 +255,16 @@ contract AVSRegistrarAsIdentifierUnitTests_registerOperator is AVSRegistrarAsIde
270255
// Register keys for the operator - Note: using AVS as the avs address in the OperatorSet
271256
for (uint32 i; i < operatorSetIds.length; ++i) {
272257
keyRegistrarMock.setIsRegistered(
273-
defaultOperator, OperatorSet({avs: AVS, id: operatorSetIds[i]}), true
258+
defaultOperator,
259+
OperatorSet({avs: address(avsRegistrarAsIdentifier), id: operatorSetIds[i]}),
260+
true
274261
);
275262
}
276263

277264
// Register operator
265+
vm.prank(address(allocationManagerMock));
278266
vm.expectEmit(true, true, true, true);
279267
emit OperatorRegistered(defaultOperator, operatorSetIds);
280-
vm.prank(address(allocationManagerMock));
281268
avsRegistrarAsIdentifier.registerOperator(
282269
defaultOperator, address(avsRegistrarAsIdentifier), operatorSetIds, "0x"
283270
);
@@ -289,29 +276,6 @@ contract AVSRegistrarAsIdentifierUnitTests_deregisterOperator is
289276
{
290277
using ArrayLib for *;
291278

292-
function setUp() public virtual override {
293-
super.setUp();
294-
295-
// Initialize the contract
296-
vm.mockCall(
297-
address(allocationManagerMock),
298-
abi.encodeWithSelector(IAllocationManager.updateAVSMetadataURI.selector),
299-
""
300-
);
301-
vm.mockCall(
302-
address(allocationManagerMock),
303-
abi.encodeWithSelector(IAllocationManager.setAVSRegistrar.selector),
304-
""
305-
);
306-
vm.mockCall(
307-
address(permissionController),
308-
abi.encodeWithSelector(IPermissionController.addPendingAdmin.selector),
309-
""
310-
);
311-
312-
// avsRegistrarAsIdentifier.initialize(admin, METADATA_URI);
313-
}
314-
315279
function testFuzz_revert_notAllocationManager(
316280
address notAllocationManager
317281
) public filterFuzzedAddressInputs(notAllocationManager) {

0 commit comments

Comments
 (0)